spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxw...@apache.org
Subject spark git commit: [SPARK-15841][Tests] REPLSuite has incorrect env set for a couple of tests.
Date Fri, 10 Jun 2016 00:46:31 GMT
Repository: spark
Updated Branches:
  refs/heads/branch-2.0 b2d076c35 -> 3119d8eef


[SPARK-15841][Tests] REPLSuite has incorrect env set for a couple of tests.

Description from JIRA.
In ReplSuite, for a test that can be tested well on just local should not really have to start
a local-cluster. And similarly a test is in-sufficiently run if it's actually fixing a problem
related to a distributed run in environment with local run.

Existing tests.

Author: Prashant Sharma <prashsh1@in.ibm.com>

Closes #13574 from ScrapCodes/SPARK-15841/repl-suite-fix.

(cherry picked from commit 83070cd1d459101e1189f3b07ea59e22f98e84ce)
Signed-off-by: Shixiong Zhu <shixiong@databricks.com>


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/3119d8ee
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/3119d8ee
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/3119d8ee

Branch: refs/heads/branch-2.0
Commit: 3119d8eef6dc2d0805c87989746cd79882b9cfea
Parents: b2d076c
Author: Prashant Sharma <prashsh1@in.ibm.com>
Authored: Thu Jun 9 17:45:37 2016 -0700
Committer: Shixiong Zhu <shixiong@databricks.com>
Committed: Thu Jun 9 17:46:28 2016 -0700

----------------------------------------------------------------------
 .../src/test/scala/org/apache/spark/repl/ReplSuite.scala         | 4 ++--
 .../src/test/scala/org/apache/spark/repl/ReplSuite.scala         | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/3119d8ee/repl/scala-2.10/src/test/scala/org/apache/spark/repl/ReplSuite.scala
----------------------------------------------------------------------
diff --git a/repl/scala-2.10/src/test/scala/org/apache/spark/repl/ReplSuite.scala b/repl/scala-2.10/src/test/scala/org/apache/spark/repl/ReplSuite.scala
index 19f201f..26b8600 100644
--- a/repl/scala-2.10/src/test/scala/org/apache/spark/repl/ReplSuite.scala
+++ b/repl/scala-2.10/src/test/scala/org/apache/spark/repl/ReplSuite.scala
@@ -233,7 +233,7 @@ class ReplSuite extends SparkFunSuite {
   }
 
   test("SPARK-1199 two instances of same class don't type check.") {
-    val output = runInterpreter("local-cluster[1,1,1024]",
+    val output = runInterpreter("local",
       """
         |case class Sum(exp: String, exp2: String)
         |val a = Sum("A", "B")
@@ -305,7 +305,7 @@ class ReplSuite extends SparkFunSuite {
   }
 
   test("SPARK-2632 importing a method from non serializable class and not using it.") {
-    val output = runInterpreter("local",
+    val output = runInterpreter("local-cluster[1,1,1024]",
     """
       |class TestClass() { def testMethod = 3 }
       |val t = new TestClass

http://git-wip-us.apache.org/repos/asf/spark/blob/3119d8ee/repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala
----------------------------------------------------------------------
diff --git a/repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala b/repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala
index 48582c1..2444e93 100644
--- a/repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala
+++ b/repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala
@@ -276,7 +276,7 @@ class ReplSuite extends SparkFunSuite {
   }
 
   test("SPARK-1199 two instances of same class don't type check.") {
-    val output = runInterpreter("local-cluster[1,1,1024]",
+    val output = runInterpreter("local",
       """
         |case class Sum(exp: String, exp2: String)
         |val a = Sum("A", "B")
@@ -336,7 +336,7 @@ class ReplSuite extends SparkFunSuite {
   }
 
   test("SPARK-2632 importing a method from non serializable class and not using it.") {
-    val output = runInterpreter("local",
+    val output = runInterpreter("local-cluster[1,1,1024]",
       """
       |class TestClass() { def testMethod = 3 }
       |val t = new TestClass


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message