spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbrad...@apache.org
Subject spark git commit: [MINOR][ML][PYSPARK] Fix omissive params which should use TypeConverter
Date Wed, 20 Apr 2016 20:02:42 GMT
Repository: spark
Updated Branches:
  refs/heads/master 8fc267ab3 -> 296c384af


[MINOR][ML][PYSPARK] Fix omissive params which should use TypeConverter

## What changes were proposed in this pull request?
#11663 adds type conversion functionality for parameters in Pyspark. This PR find out the
omissive ```Param``` that did not pass corresponding ```TypeConverter``` argument and fix
them. After this PR, all params in pyspark/ml/ used ```TypeConverter```.

## How was this patch tested?
Existing tests.

cc jkbradley sethah

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #12529 from yanboliang/typeConverter.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/296c384a
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/296c384a
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/296c384a

Branch: refs/heads/master
Commit: 296c384aff5bc1c0e8d411669f8f3e082cdf8f55
Parents: 8fc267a
Author: Yanbo Liang <ybliang8@gmail.com>
Authored: Wed Apr 20 13:02:37 2016 -0700
Committer: Joseph K. Bradley <joseph@databricks.com>
Committed: Wed Apr 20 13:02:37 2016 -0700

----------------------------------------------------------------------
 python/pyspark/ml/regression.py | 7 ++++---
 python/pyspark/ml/tuning.py     | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/296c384a/python/pyspark/ml/regression.py
----------------------------------------------------------------------
diff --git a/python/pyspark/ml/regression.py b/python/pyspark/ml/regression.py
index da74ab5..8e76070 100644
--- a/python/pyspark/ml/regression.py
+++ b/python/pyspark/ml/regression.py
@@ -561,7 +561,7 @@ class TreeRegressorParams(Params):
     impurity = Param(Params._dummy(), "impurity",
                      "Criterion used for information gain calculation (case-insensitive).
" +
                      "Supported options: " +
-                     ", ".join(supportedImpurities))
+                     ", ".join(supportedImpurities), typeConverter=TypeConverters.toString)
 
     def __init__(self):
         super(TreeRegressorParams, self).__init__()
@@ -1261,11 +1261,12 @@ class GeneralizedLinearRegression(JavaEstimator, HasLabelCol, HasFeaturesCol,
Ha
 
     family = Param(Params._dummy(), "family", "The name of family which is a description
of " +
                    "the error distribution to be used in the model. Supported options: "
+
-                   "gaussian(default), binomial, poisson and gamma.")
+                   "gaussian(default), binomial, poisson and gamma.",
+                   typeConverter=TypeConverters.toString)
     link = Param(Params._dummy(), "link", "The name of link function which provides the "
+
                  "relationship between the linear predictor and the mean of the distribution
" +
                  "function. Supported options: identity, log, inverse, logit, probit, cloglog
" +
-                 "and sqrt.")
+                 "and sqrt.", typeConverter=TypeConverters.toString)
 
     @keyword_only
     def __init__(self, labelCol="label", featuresCol="features", predictionCol="prediction",

http://git-wip-us.apache.org/repos/asf/spark/blob/296c384a/python/pyspark/ml/tuning.py
----------------------------------------------------------------------
diff --git a/python/pyspark/ml/tuning.py b/python/pyspark/ml/tuning.py
index ef14da4..b16628b 100644
--- a/python/pyspark/ml/tuning.py
+++ b/python/pyspark/ml/tuning.py
@@ -448,7 +448,7 @@ class TrainValidationSplit(Estimator, ValidatorParams, MLReadable, MLWritable):
     """
 
     trainRatio = Param(Params._dummy(), "trainRatio", "Param for ratio between train and\
-     validation data. Must be between 0 and 1.")
+     validation data. Must be between 0 and 1.", typeConverter=TypeConverters.toFloat)
 
     @keyword_only
     def __init__(self, estimator=None, estimatorParamMaps=None, evaluator=None, trainRatio=0.75,


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message