spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewo...@apache.org
Subject spark git commit: [SPARK-5095] remove flaky test
Date Fri, 12 Feb 2016 23:00:42 GMT
Repository: spark
Updated Branches:
  refs/heads/master 38bc6018e -> 62b1c07e7


[SPARK-5095] remove flaky test

Overrode the start() method, which was previously starting a thread causing a race condition.
I believe this should fix the flaky test.

Author: Michael Gummelt <mgummelt@mesosphere.io>

Closes #11164 from mgummelt/fix_mesos_tests.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/62b1c07e
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/62b1c07e
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/62b1c07e

Branch: refs/heads/master
Commit: 62b1c07e7e88fe9c951c59cf022dfd52f160cfeb
Parents: 38bc601
Author: Michael Gummelt <mgummelt@mesosphere.io>
Authored: Fri Feb 12 15:00:39 2016 -0800
Committer: Andrew Or <andrew@databricks.com>
Committed: Fri Feb 12 15:00:39 2016 -0800

----------------------------------------------------------------------
 .../cluster/mesos/CoarseMesosSchedulerBackendSuite.scala        | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/62b1c07e/core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackendSuite.scala
----------------------------------------------------------------------
diff --git a/core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackendSuite.scala
b/core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackendSuite.scala
index 5e01d95..5db7535 100644
--- a/core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackendSuite.scala
+++ b/core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackendSuite.scala
@@ -300,6 +300,11 @@ class CoarseMesosSchedulerBackendSuite extends SparkFunSuite
       override protected def createDriverEndpointRef(
           properties: ArrayBuffer[(String, String)]): RpcEndpointRef = endpoint
 
+      // override to avoid race condition with the driver thread on `mesosDriver`
+      override def startScheduler(newDriver: SchedulerDriver): Unit = {
+        mesosDriver = newDriver
+      }
+
       markRegistered()
     }
     backend.start()


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message