spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r...@apache.org
Subject spark git commit: [SPARK-12692][BUILD] Enforce style checking about white space before comma
Date Wed, 13 Jan 2016 08:51:27 GMT
Repository: spark
Updated Branches:
  refs/heads/master cb7b864a2 -> 3d81d63f4


[SPARK-12692][BUILD] Enforce style checking about white space before comma

This is the final PR about SPARK-12692.
We have removed all of white spaces before comma from code so let's enforce style checking.

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes #10736 from sarutak/SPARK-12692-followup-enforce-checking.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/3d81d63f
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/3d81d63f
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/3d81d63f

Branch: refs/heads/master
Commit: 3d81d63f4499478ef7861bf77383c30aed14bb19
Parents: cb7b864
Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
Authored: Wed Jan 13 00:51:24 2016 -0800
Committer: Reynold Xin <rxin@databricks.com>
Committed: Wed Jan 13 00:51:24 2016 -0800

----------------------------------------------------------------------
 scalastyle-config.xml | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/3d81d63f/scalastyle-config.xml
----------------------------------------------------------------------
diff --git a/scalastyle-config.xml b/scalastyle-config.xml
index bc209ee..967a482 100644
--- a/scalastyle-config.xml
+++ b/scalastyle-config.xml
@@ -197,6 +197,12 @@ This file is divided into 3 sections:
     </parameters>
   </check>
 
+  <check level="error" class="org.scalastyle.scalariform.DisallowSpaceBeforeTokenChecker"
enabled="true">
+    <parameters>
+      <parameter name="tokens">COMMA</parameter>
+    </parameters>
+  </check>
+
   <!-- ================================================================================
-->
   <!--       rules we'd like to enforce, but haven't cleaned up the codebase yet     
  -->
   <!-- ================================================================================
-->
@@ -217,13 +223,6 @@ This file is divided into 3 sections:
   <!-- Should turn this on, but we have a few places that need to be fixed first -->
   <check level="error" class="org.scalastyle.scalariform.EqualsHashCodeChecker" enabled="false"></check>
 
-  <!-- Should turn this on, but we have a few places that need to be fixed first -->
-  <check level="warning" class="org.scalastyle.scalariform.DisallowSpaceBeforeTokenChecker"
enabled="true">
-    <parameters>
-      <parameter name="tokens">COMMA</parameter>
-    </parameters>
-  </check>
-
   <!-- ================================================================================
-->
   <!--                               rules we don't want                             
  -->
   <!-- ================================================================================
-->


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message