spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dav...@apache.org
Subject spark git commit: [PYSPARK] Pyspark typo & Add missing abstractmethod annotation
Date Mon, 21 Dec 2015 17:40:34 GMT
Repository: spark
Updated Branches:
  refs/heads/master d0f695089 -> 1920d72a1


[PYSPARK] Pyspark typo & Add missing abstractmethod annotation

No jira is created since this is a trivial change.

davies  Please help review it

Author: Jeff Zhang <zjffdu@apache.org>

Closes #10143 from zjffdu/pyspark_typo.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/1920d72a
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/1920d72a
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/1920d72a

Branch: refs/heads/master
Commit: 1920d72a1f7b9844323d06e8094818347f413df6
Parents: d0f6950
Author: Jeff Zhang <zjffdu@apache.org>
Authored: Mon Dec 21 08:53:46 2015 -0800
Committer: Davies Liu <davies.liu@gmail.com>
Committed: Mon Dec 21 08:53:46 2015 -0800

----------------------------------------------------------------------
 python/pyspark/ml/pipeline.py | 2 +-
 python/pyspark/ml/wrapper.py  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/1920d72a/python/pyspark/ml/pipeline.py
----------------------------------------------------------------------
diff --git a/python/pyspark/ml/pipeline.py b/python/pyspark/ml/pipeline.py
index 4475451..9f5f6ac 100644
--- a/python/pyspark/ml/pipeline.py
+++ b/python/pyspark/ml/pipeline.py
@@ -86,7 +86,7 @@ class Transformer(Params):
     @abstractmethod
     def _transform(self, dataset):
         """
-        Transforms the input dataset with optional parameters.
+        Transforms the input dataset.
 
         :param dataset: input dataset, which is an instance of
                         :py:class:`pyspark.sql.DataFrame`

http://git-wip-us.apache.org/repos/asf/spark/blob/1920d72a/python/pyspark/ml/wrapper.py
----------------------------------------------------------------------
diff --git a/python/pyspark/ml/wrapper.py b/python/pyspark/ml/wrapper.py
index 4bcb4aa..dd1d4b0 100644
--- a/python/pyspark/ml/wrapper.py
+++ b/python/pyspark/ml/wrapper.py
@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-from abc import ABCMeta
+from abc import ABCMeta, abstractmethod
 
 from pyspark import SparkContext
 from pyspark.sql import DataFrame
@@ -110,6 +110,7 @@ class JavaEstimator(Estimator, JavaWrapper):
 
     __metaclass__ = ABCMeta
 
+    @abstractmethod
     def _create_model(self, java_model):
         """
         Creates a model from the input Java model reference.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message