spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sro...@apache.org
Subject spark git commit: [SPARK-11824][WEBUI] WebUI does not render descriptions with 'bad' HTML, throws console error
Date Wed, 09 Dec 2015 19:48:01 GMT
Repository: spark
Updated Branches:
  refs/heads/branch-1.6 05e441e12 -> ee0a6e722


[SPARK-11824][WEBUI] WebUI does not render descriptions with 'bad' HTML, throws console error

Don't warn when description isn't valid HTML since it may properly be like "SELECT ... where
foo <= 1"

The tests for this code indicate that it's normal to handle strings like this that don't contain
HTML as a string rather than markup. Hence logging every such instance as a warning is too
noisy since it's not a problem. this is an issue for stages whose name contain SQL like the
above

CC tdas as author of this bit of code

Author: Sean Owen <sowen@cloudera.com>

Closes #10159 from srowen/SPARK-11824.

(cherry picked from commit 1eb7c22ce72a1b82ed194a51bbcf0da9c771605a)
Signed-off-by: Sean Owen <sowen@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/ee0a6e72
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/ee0a6e72
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/ee0a6e72

Branch: refs/heads/branch-1.6
Commit: ee0a6e72234e4f672a2939b794c904026f696398
Parents: 05e441e
Author: Sean Owen <sowen@cloudera.com>
Authored: Wed Dec 9 19:47:38 2015 +0000
Committer: Sean Owen <sowen@cloudera.com>
Committed: Wed Dec 9 19:47:51 2015 +0000

----------------------------------------------------------------------
 core/src/main/scala/org/apache/spark/ui/UIUtils.scala | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/ee0a6e72/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/UIUtils.scala b/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
index 1e8194f..81a6f07 100644
--- a/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
+++ b/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
@@ -448,7 +448,6 @@ private[spark] object UIUtils extends Logging {
       new RuleTransformer(rule).transform(xml)
     } catch {
       case NonFatal(e) =>
-        logWarning(s"Invalid job description: $desc ", e)
         <span class="description-input">{desc}</span>
     }
   }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message