spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxw...@apache.org
Subject spark git commit: [SPARK-12490][CORE] Limit the css style scope to fix the Streaming UI
Date Wed, 30 Dec 2015 03:54:16 GMT
Repository: spark
Updated Branches:
  refs/heads/master b600bccf4 -> 7ab0e2289


[SPARK-12490][CORE] Limit the css style scope to fix the Streaming UI

#10441 broke the Streaming UI because of the new CSS style.

<img width="503" alt="screen shot 2015-12-29 at 4 49 04 pm" src="https://cloud.githubusercontent.com/assets/1000778/12044763/1efce0fe-ae4c-11e5-9f8b-39df08426bf8.png">

This PR just added a class for the new style and only applied them to the paged tables.

Author: Shixiong Zhu <shixiong@databricks.com>

Closes #10517 from zsxwing/fix-streaming-ui.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/7ab0e228
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/7ab0e228
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/7ab0e228

Branch: refs/heads/master
Commit: 7ab0e2289df39eed03b0b8c8b2b350faf2b4e4ee
Parents: b600bcc
Author: Shixiong Zhu <shixiong@databricks.com>
Authored: Tue Dec 29 19:54:10 2015 -0800
Committer: Shixiong Zhu <shixiong@databricks.com>
Committed: Tue Dec 29 19:54:10 2015 -0800

----------------------------------------------------------------------
 core/src/main/resources/org/apache/spark/ui/static/webui.css  | 2 +-
 core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala  | 3 ++-
 core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala | 3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/7ab0e228/core/src/main/resources/org/apache/spark/ui/static/webui.css
----------------------------------------------------------------------
diff --git a/core/src/main/resources/org/apache/spark/ui/static/webui.css b/core/src/main/resources/org/apache/spark/ui/static/webui.css
index dd708ef..48f86d1 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/webui.css
+++ b/core/src/main/resources/org/apache/spark/ui/static/webui.css
@@ -227,7 +227,7 @@ a.expandbutton {
   cursor:pointer;
 }
 
-th a, th a:hover {
+.table-head-clickable th a, .table-head-clickable th a:hover {
   /* Make the entire header clickable, not just the text label */
   display: block;
   width: 100%;

http://git-wip-us.apache.org/repos/asf/spark/blob/7ab0e228/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala b/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
index b02b99a..08e7576 100644
--- a/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
@@ -1233,7 +1233,8 @@ private[ui] class TaskPagedTable(
 
   override def tableId: String = "task-table"
 
-  override def tableCssClass: String = "table table-bordered table-condensed table-striped"
+  override def tableCssClass: String =
+    "table table-bordered table-condensed table-striped table-head-clickable"
 
   override def pageSizeFormField: String = "task.pageSize"
 

http://git-wip-us.apache.org/repos/asf/spark/blob/7ab0e228/core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala b/core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala
index 3e51ce2..606d15d 100644
--- a/core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala
@@ -237,7 +237,8 @@ private[ui] class BlockPagedTable(
 
   override def tableId: String = "rdd-storage-by-block-table"
 
-  override def tableCssClass: String = "table table-bordered table-condensed table-striped"
+  override def tableCssClass: String =
+    "table table-bordered table-condensed table-striped table-head-clickable"
 
   override def pageSizeFormField: String = "block.pageSize"
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message