spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r...@apache.org
Subject spark git commit: [SPARK-11165] Logging trait should be private - not DeveloperApi.
Date Sat, 17 Oct 2015 19:42:03 GMT
Repository: spark
Updated Branches:
  refs/heads/master cca225868 -> 254937420


[SPARK-11165] Logging trait should be private - not DeveloperApi.

Its classdoc actually says; "NOTE: DO NOT USE this class outside of Spark. It is intended
as an internal utility."

Author: Reynold Xin <rxin@databricks.com>

Closes #9155 from rxin/private-logging-trait.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/25493742
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/25493742
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/25493742

Branch: refs/heads/master
Commit: 254937420678a299f06b6f4e2696c623da56cf3a
Parents: cca2258
Author: Reynold Xin <rxin@databricks.com>
Authored: Sat Oct 17 12:41:42 2015 -0700
Committer: Reynold Xin <rxin@databricks.com>
Committed: Sat Oct 17 12:41:42 2015 -0700

----------------------------------------------------------------------
 core/src/main/scala/org/apache/spark/Logging.scala | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/25493742/core/src/main/scala/org/apache/spark/Logging.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/Logging.scala b/core/src/main/scala/org/apache/spark/Logging.scala
index f059881..69f6e06 100644
--- a/core/src/main/scala/org/apache/spark/Logging.scala
+++ b/core/src/main/scala/org/apache/spark/Logging.scala
@@ -21,11 +21,10 @@ import org.apache.log4j.{LogManager, PropertyConfigurator}
 import org.slf4j.{Logger, LoggerFactory}
 import org.slf4j.impl.StaticLoggerBinder
 
-import org.apache.spark.annotation.DeveloperApi
+import org.apache.spark.annotation.Private
 import org.apache.spark.util.Utils
 
 /**
- * :: DeveloperApi ::
  * Utility trait for classes that want to log data. Creates a SLF4J logger for the class
and allows
  * logging messages at different levels using methods that only evaluate parameters lazily
if the
  * log level is enabled.
@@ -33,7 +32,7 @@ import org.apache.spark.util.Utils
  * NOTE: DO NOT USE this class outside of Spark. It is intended as an internal utility.
  *       This will likely be changed or removed in future releases.
  */
-@DeveloperApi
+@Private
 trait Logging {
   // Make the log field transient so that objects with Logging can
   // be serialized and used on another machine


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message