spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From van...@apache.org
Subject spark git commit: [SPARK-10172] [CORE] disable sort in HistoryServer webUI
Date Thu, 17 Sep 2015 17:18:45 GMT
Repository: spark
Updated Branches:
  refs/heads/branch-1.5 9f8fb3385 -> 88176d1a2


[SPARK-10172] [CORE] disable sort in HistoryServer webUI

This pull request is to address the JIRA SPARK-10172 (History Server web UI gets messed up
when sorting on any column).
The content of the table gets messed up due to the rowspan attribute of the table data(cell)
during sorting.
The current table sort library used in SparkUI (sorttable.js) doesn't support/handle cells(td)
with rowspans.
The fix will disable the table sort in the web UI, when there are jobs listed with multiple
attempts.

Author: Josiah Samuel <josiah_sams@in.ibm.com>

Closes #8506 from josiahsams/SPARK-10172.

(cherry picked from commit 81b4db374dd61b6f1c30511c70b6ab2a52c68faa)
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/88176d1a
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/88176d1a
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/88176d1a

Branch: refs/heads/branch-1.5
Commit: 88176d1a283e215843dfd4d6b8fa9b9c5e9b00b2
Parents: 9f8fb33
Author: Josiah Samuel <josiah_sams@in.ibm.com>
Authored: Thu Sep 17 10:18:21 2015 -0700
Committer: Marcelo Vanzin <vanzin@cloudera.com>
Committed: Thu Sep 17 10:18:36 2015 -0700

----------------------------------------------------------------------
 .../scala/org/apache/spark/deploy/history/HistoryPage.scala     | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/88176d1a/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala b/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala
index 0830cc1..b347cb3 100644
--- a/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala
+++ b/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala
@@ -51,7 +51,10 @@ private[history] class HistoryPage(parent: HistoryServer) extends WebUIPage("")
     val hasMultipleAttempts = appsToShow.exists(_.attempts.size > 1)
     val appTable =
       if (hasMultipleAttempts) {
-        UIUtils.listingTable(appWithAttemptHeader, appWithAttemptRow, appsToShow)
+        // Sorting is disable here as table sort on rowspan has issues.
+        // ref. SPARK-10172
+        UIUtils.listingTable(appWithAttemptHeader, appWithAttemptRow,
+          appsToShow, sortable = false)
       } else {
         UIUtils.listingTable(appHeader, appRow, appsToShow)
       }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message