spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shiva...@apache.org
Subject spark git commit: [SPARK-9121] [SPARKR] Get rid of the warnings about `no visible global function definition` in SparkR
Date Wed, 22 Jul 2015 05:50:33 GMT
Repository: spark
Updated Branches:
  refs/heads/master a4c83cb1e -> 63f4bcc73


[SPARK-9121] [SPARKR] Get rid of the warnings about `no visible global function definition`
in SparkR

[[SPARK-9121] Get rid of the warnings about `no visible global function definition` in SparkR
- ASF JIRA](https://issues.apache.org/jira/browse/SPARK-9121)

## The Result of `dev/lint-r`
[The result of lint-r for SPARK-9121 at the revision:1ddd0f2f1688560f88470e312b72af04364e2d49
when I have sent a PR](https://gist.github.com/yu-iskw/6f55953425901725edf6)

Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com>

Closes #7567 from yu-iskw/SPARK-9121 and squashes the following commits:

c8cfd63 [Yu ISHIKAWA] Fix the typo
b1f19ed [Yu ISHIKAWA] Add a validate statement for local SparkR
1a03987 [Yu ISHIKAWA] Load the `testthat` package in `dev/lint-r.R`, instead of using the
full path of function.
3a5e0ab [Yu ISHIKAWA] [SPARK-9121][SparkR] Get rid of the warnings about `no visible global
function definition` in SparkR


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/63f4bcc7
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/63f4bcc7
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/63f4bcc7

Branch: refs/heads/master
Commit: 63f4bcc73f5a09c1790cc3c333f08b18609de6a4
Parents: a4c83cb
Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com>
Authored: Tue Jul 21 22:50:27 2015 -0700
Committer: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
Committed: Tue Jul 21 22:50:27 2015 -0700

----------------------------------------------------------------------
 dev/lint-r.R | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/63f4bcc7/dev/lint-r.R
----------------------------------------------------------------------
diff --git a/dev/lint-r.R b/dev/lint-r.R
index dcb1a18..48bd624 100644
--- a/dev/lint-r.R
+++ b/dev/lint-r.R
@@ -15,15 +15,21 @@
 # limitations under the License.
 #
 
+argv <- commandArgs(TRUE)
+SPARK_ROOT_DIR <- as.character(argv[1])
+
 # Installs lintr from Github.
 # NOTE: The CRAN's version is too old to adapt to our rules.
 if ("lintr" %in% row.names(installed.packages())  == FALSE) {
   devtools::install_github("jimhester/lintr")
 }
-library(lintr)
 
-argv <- commandArgs(TRUE)
-SPARK_ROOT_DIR <- as.character(argv[1])
+library(lintr)
+library(methods)
+library(testthat)
+if (! library(SparkR, lib.loc = file.path(SPARK_ROOT_DIR, "R", "lib"), logical.return = TRUE))
{
+  stop("You should install SparkR in a local directory with `R/install-dev.sh`.")
+}
 
 path.to.package <- file.path(SPARK_ROOT_DIR, "R", "pkg")
 lint_package(path.to.package, cache = FALSE)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message