spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmb...@apache.org
Subject git commit: [SPARK-3481][SQL] Removes the evil MINOR HACK
Date Sat, 13 Sep 2014 19:35:44 GMT
Repository: spark
Updated Branches:
  refs/heads/master a523ceaf1 -> 184cd51c4


[SPARK-3481][SQL] Removes the evil MINOR HACK

This is a follow up of #2352. Now we can finally remove the evil "MINOR HACK", which covered
up the eldest bug in the history of Spark SQL (see details [here](https://github.com/apache/spark/pull/2352#issuecomment-55440621)).

Author: Cheng Lian <lian.cs.zju@gmail.com>

Closes #2377 from liancheng/remove-evil-minor-hack and squashes the following commits:

0869c78 [Cheng Lian] Removes the evil MINOR HACK


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/184cd51c
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/184cd51c
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/184cd51c

Branch: refs/heads/master
Commit: 184cd51c4207c23726da97f907f2d912a5a44845
Parents: a523cea
Author: Cheng Lian <lian.cs.zju@gmail.com>
Authored: Sat Sep 13 12:35:40 2014 -0700
Committer: Michael Armbrust <michael@databricks.com>
Committed: Sat Sep 13 12:35:40 2014 -0700

----------------------------------------------------------------------
 .../apache/spark/sql/hive/execution/HiveComparisonTest.scala   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/184cd51c/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala
b/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala
index 671c3b1..79cc7a3 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala
@@ -250,9 +250,9 @@ abstract class HiveComparisonTest
       }
 
       try {
-        // MINOR HACK: You must run a query before calling reset the first time.
-        TestHive.sql("SHOW TABLES")
-        if (reset) { TestHive.reset() }
+        if (reset) {
+          TestHive.reset()
+        }
 
         val hiveCacheFiles = queryList.zipWithIndex.map {
           case (queryString, i)  =>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message