spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshro...@apache.org
Subject git commit: SPARK-3331 [BUILD] PEP8 tests fail because they check unzipped py4j code
Date Tue, 02 Sep 2014 17:30:33 GMT
Repository: spark
Updated Branches:
  refs/heads/master 0f16b23cd -> 32ec0a8cd


SPARK-3331 [BUILD] PEP8 tests fail because they check unzipped py4j code

PEP8 tests run on files under "./python", but unzipped py4j code is found at "./python/build/py4j".
Py4J code fails style checks and can fail ./dev/run-tests if this code is present locally.

Author: Sean Owen <sowen@cloudera.com>

Closes #2222 from srowen/SPARK-3331 and squashes the following commits:

34711ec [Sean Owen] Restrict lint check to pyspark/, since the local directory can contain
unzipped py4j code in build/py4j


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/32ec0a8c
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/32ec0a8c
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/32ec0a8c

Branch: refs/heads/master
Commit: 32ec0a8cd4020f1e8ef2997de310823b566ab2de
Parents: 0f16b23
Author: Sean Owen <sowen@cloudera.com>
Authored: Tue Sep 2 10:30:26 2014 -0700
Committer: Josh Rosen <joshrosen@apache.org>
Committed: Tue Sep 2 10:30:26 2014 -0700

----------------------------------------------------------------------
 dev/lint-python | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/32ec0a8c/dev/lint-python
----------------------------------------------------------------------
diff --git a/dev/lint-python b/dev/lint-python
index 4efddad..a1e890f 100755
--- a/dev/lint-python
+++ b/dev/lint-python
@@ -44,7 +44,7 @@ fi
 #+ first, but we do so so that the check status can
 #+ be output before the report, like with the
 #+ scalastyle and RAT checks.
-python $PEP8_SCRIPT_PATH ./python > "$PEP8_REPORT_PATH"
+python $PEP8_SCRIPT_PATH ./python/pyspark > "$PEP8_REPORT_PATH"
 pep8_status=${PIPESTATUS[0]} #$?
 
 if [ $pep8_status -ne 0 ]; then


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message