spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwend...@apache.org
Subject git commit: HOTFIX: Remove persistently failing test in master.
Date Thu, 10 Jul 2014 02:45:09 GMT
Repository: spark
Updated Branches:
  refs/heads/master dd22bc2d5 -> 553c578de


HOTFIX: Remove persistently failing test in master.

Apparently this functionality is going to be removed soon anywyas.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/553c578d
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/553c578d
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/553c578d

Branch: refs/heads/master
Commit: 553c578de1a73a605197c184fc028efcc8dff010
Parents: dd22bc2
Author: Patrick Wendell <pwendell@gmail.com>
Authored: Wed Jul 9 19:44:24 2014 -0700
Committer: Patrick Wendell <pwendell@gmail.com>
Committed: Wed Jul 9 19:44:24 2014 -0700

----------------------------------------------------------------------
 .../scala/org/apache/spark/sql/JoinSuite.scala  | 28 --------------------
 1 file changed, 28 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/553c578d/sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
index 3d7d5ee..e17ecc8 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
@@ -36,34 +36,6 @@ class JoinSuite extends QueryTest {
     assert(planned.size === 1)
   }
 
-  test("plans broadcast hash join, given hints") {
-
-    def mkTest(buildSide: BuildSide, leftTable: String, rightTable: String) = {
-      TestSQLContext.set("spark.sql.join.broadcastTables",
-        s"${if (buildSide == BuildRight) rightTable else leftTable}")
-      val rdd = sql(s"""SELECT * FROM $leftTable JOIN $rightTable ON key = a""")
-      // Using `sparkPlan` because for relevant patterns in HashJoin to be
-      // matched, other strategies need to be applied.
-      val physical = rdd.queryExecution.sparkPlan
-      val bhj = physical.collect { case j: BroadcastHashJoin if j.buildSide == buildSide
=> j }
-
-      assert(bhj.size === 1, "planner does not pick up hint to generate broadcast hash join")
-      checkAnswer(
-        rdd,
-        Seq(
-          (1, "1", 1, 1),
-          (1, "1", 1, 2),
-          (2, "2", 2, 1),
-          (2, "2", 2, 2),
-          (3, "3", 3, 1),
-          (3, "3", 3, 2)
-        ))
-    }
-
-    mkTest(BuildRight, "testData", "testData2")
-    mkTest(BuildLeft, "testData", "testData2")
-  }
-
   test("multiple-key equi-join is hash-join") {
     val x = testData2.as('x)
     val y = testData2.as('y)


Mime
View raw message