spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r...@apache.org
Subject git commit: [SQL] Use hive.SessionState, not the thread local SessionState
Date Sat, 21 Jun 2014 00:56:29 GMT
Repository: spark
Updated Branches:
  refs/heads/branch-1.0 91dc0641c -> 36668662f


[SQL] Use hive.SessionState, not the thread local SessionState

Note that this is simply mimicing lookupRelation(). I do not have a concrete notion of why
this solution is necessarily right-er than SessionState.get, but SessionState.get is returning
null, which is bad.

Author: Aaron Davidson <aaron@databricks.com>

Closes #1148 from aarondav/createtable and squashes the following commits:

37c3e7c [Aaron Davidson] [SQL] Use hive.SessionState, not the thread local SessionState

(cherry picked from commit 2044784915554a890ca6f8450d8403495b2ee4f3)
Signed-off-by: Reynold Xin <rxin@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/36668662
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/36668662
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/36668662

Branch: refs/heads/branch-1.0
Commit: 36668662f6a6842d90c83a1f83e612d7a3f09831
Parents: 91dc064
Author: Aaron Davidson <aaron@databricks.com>
Authored: Fri Jun 20 17:55:54 2014 -0700
Committer: Reynold Xin <rxin@apache.org>
Committed: Fri Jun 20 17:56:26 2014 -0700

----------------------------------------------------------------------
 .../scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/36668662/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
b/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
index f923d68..faa30c9 100644
--- a/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
+++ b/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
@@ -105,7 +105,7 @@ private[hive] class HiveMetastoreCatalog(hive: HiveContext) extends Catalog
with
   object CreateTables extends Rule[LogicalPlan] {
     def apply(plan: LogicalPlan): LogicalPlan = plan transform {
       case InsertIntoCreatedTable(db, tableName, child) =>
-        val databaseName = db.getOrElse(SessionState.get.getCurrentDatabase)
+        val databaseName = db.getOrElse(hive.sessionState.getCurrentDatabase)
 
         createTable(databaseName, tableName, child.output)
 


Mime
View raw message