Return-Path: X-Original-To: apmail-spark-commits-archive@minotaur.apache.org Delivered-To: apmail-spark-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C0EC0112B2 for ; Thu, 15 May 2014 10:11:39 +0000 (UTC) Received: (qmail 30688 invoked by uid 500); 15 May 2014 04:14:40 -0000 Delivered-To: apmail-spark-commits-archive@spark.apache.org Received: (qmail 30662 invoked by uid 500); 15 May 2014 04:14:40 -0000 Mailing-List: contact commits-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@spark.apache.org Delivered-To: mailing list commits@spark.apache.org Received: (qmail 30641 invoked by uid 99); 15 May 2014 04:14:40 -0000 Received: from Unknown (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 May 2014 04:14:40 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 5471D902BEA; Thu, 15 May 2014 04:14:25 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: pwendell@apache.org To: commits@spark.apache.org Message-Id: <9b5f7ba0b0f74223b704352a073c24dd@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: git commit: [SPARK-1840] SparkListenerBus prints out scary error message when terminated normally Date: Thu, 15 May 2014 04:14:25 +0000 (UTC) Repository: spark Updated Branches: refs/heads/branch-1.0 9f0f2ecb8 -> ba871235f [SPARK-1840] SparkListenerBus prints out scary error message when terminated normally Running SparkPi example gave this error. ``` Pi is roughly 3.14374 14/05/14 18:16:19 ERROR Utils: Uncaught exception in thread SparkListenerBus scala.runtime.NonLocalReturnControl$mcV$sp ``` This is due to the catch-all in the SparkListenerBus, which logged control throwable used by scala system Author: Tathagata Das Closes #783 from tdas/controlexception-fix and squashes the following commits: a466c8d [Tathagata Das] Ignored control exceptions when logging all exceptions. (cherry picked from commit ad4e60ee7e2c49c24a9972312915f7f7253c7679) Signed-off-by: Patrick Wendell Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/ba871235 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/ba871235 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/ba871235 Branch: refs/heads/branch-1.0 Commit: ba871235f0d01093475547e74a125c10dd2123bb Parents: 9f0f2ec Author: Tathagata Das Authored: Wed May 14 21:13:41 2014 -0700 Committer: Patrick Wendell Committed: Wed May 14 21:14:21 2014 -0700 ---------------------------------------------------------------------- core/src/main/scala/org/apache/spark/util/Utils.scala | 2 ++ 1 file changed, 2 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/ba871235/core/src/main/scala/org/apache/spark/util/Utils.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/util/Utils.scala b/core/src/main/scala/org/apache/spark/util/Utils.scala index d041bfa..388f722 100644 --- a/core/src/main/scala/org/apache/spark/util/Utils.scala +++ b/core/src/main/scala/org/apache/spark/util/Utils.scala @@ -1149,6 +1149,8 @@ private[spark] object Utils extends Logging { try { f } catch { + case ct: ControlThrowable => + throw ct case t: Throwable => logError(s"Uncaught exception in thread ${Thread.currentThread().getName}", t) throw t