spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwend...@apache.org
Subject git commit: SPARK-1629. Addendum: Depend on commons lang3 (already used by tachyon) as it's used in ReplSuite, and return to use lang3 utility in Utils.scala
Date Mon, 05 May 2014 00:43:49 GMT
Repository: spark
Updated Branches:
  refs/heads/master 0c98a8f6a -> f5041579f


SPARK-1629. Addendum: Depend on commons lang3 (already used by tachyon) as it's used in ReplSuite,
and return to use lang3 utility in Utils.scala

For consideration. This was proposed in related discussion: https://github.com/apache/spark/pull/569

Author: Sean Owen <sowen@cloudera.com>

Closes #635 from srowen/SPARK-1629.2 and squashes the following commits:

a442b98 [Sean Owen] Depend on commons lang3 (already used by tachyon) as it's used in ReplSuite,
and return to use lang3 utility in Utils.scala


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/f5041579
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/f5041579
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/f5041579

Branch: refs/heads/master
Commit: f5041579ff573f988b673c2506fa4edc32f5ad84
Parents: 0c98a8f
Author: Sean Owen <sowen@cloudera.com>
Authored: Sun May 4 17:43:28 2014 -0700
Committer: Patrick Wendell <pwendell@gmail.com>
Committed: Sun May 4 17:43:35 2014 -0700

----------------------------------------------------------------------
 core/pom.xml                                          | 4 ++++
 core/src/main/scala/org/apache/spark/util/Utils.scala | 5 ++---
 pom.xml                                               | 5 +++++
 project/SparkBuild.scala                              | 1 +
 4 files changed, 12 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/f5041579/core/pom.xml
----------------------------------------------------------------------
diff --git a/core/pom.xml b/core/pom.xml
index 822b5b1..36c71e6 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -70,6 +70,10 @@
       <artifactId>guava</artifactId>
     </dependency>
     <dependency>
+      <groupId>org.apache.commons</groupId>
+      <artifactId>commons-lang3</artifactId>
+    </dependency>
+    <dependency>
       <groupId>com.google.code.findbugs</groupId>
       <artifactId>jsr305</artifactId>
     </dependency>

http://git-wip-us.apache.org/repos/asf/spark/blob/f5041579/core/src/main/scala/org/apache/spark/util/Utils.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/util/Utils.scala b/core/src/main/scala/org/apache/spark/util/Utils.scala
index acd7eef..bef4dab 100644
--- a/core/src/main/scala/org/apache/spark/util/Utils.scala
+++ b/core/src/main/scala/org/apache/spark/util/Utils.scala
@@ -32,6 +32,7 @@ import scala.util.Try
 
 import com.google.common.io.Files
 import com.google.common.util.concurrent.ThreadFactoryBuilder
+import org.apache.commons.lang3.SystemUtils
 import org.apache.hadoop.fs.{FileSystem, FileUtil, Path}
 import org.json4s._
 import tachyon.client.{TachyonFile,TachyonFS}
@@ -1073,9 +1074,7 @@ private[spark] object Utils extends Logging {
   /**
    * Return true if this is Windows.
    */
-  def isWindows = {
-    Option(System.getProperty("os.name")).exists(_.startsWith("Windows"))
-  }
+  def isWindows = SystemUtils.IS_OS_WINDOWS
 
   /**
    * Indicates whether Spark is currently running unit tests.

http://git-wip-us.apache.org/repos/asf/spark/blob/f5041579/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index ebd359a..7678043 100644
--- a/pom.xml
+++ b/pom.xml
@@ -222,6 +222,11 @@
         <version>14.0.1</version>
       </dependency>
       <dependency>
+        <groupId>org.apache.commons</groupId>
+        <artifactId>commons-lang3</artifactId>
+        <version>3.3.2</version>
+      </dependency>
+      <dependency>
         <groupId>com.google.code.findbugs</groupId>
         <artifactId>jsr305</artifactId>
         <version>1.3.9</version>

http://git-wip-us.apache.org/repos/asf/spark/blob/f5041579/project/SparkBuild.scala
----------------------------------------------------------------------
diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala
index 51f7335..19aa3c0 100644
--- a/project/SparkBuild.scala
+++ b/project/SparkBuild.scala
@@ -326,6 +326,7 @@ object SparkBuild extends Build {
     name := "spark-core",
     libraryDependencies ++= Seq(
         "com.google.guava"           % "guava"            % "14.0.1",
+        "org.apache.commons"         % "commons-lang3"    % "3.3.2",
         "com.google.code.findbugs"   % "jsr305"           % "1.3.9",
         "log4j"                      % "log4j"            % "1.2.17",
         "org.slf4j"                  % "slf4j-api"        % slf4jVersion,


Mime
View raw message