spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwend...@apache.org
Subject git commit: [SPARK-1840] SparkListenerBus prints out scary error message when terminated normally
Date Thu, 15 May 2014 04:14:25 GMT
Repository: spark
Updated Branches:
  refs/heads/branch-1.0 9f0f2ecb8 -> ba871235f


[SPARK-1840] SparkListenerBus prints out scary error message when terminated normally

Running SparkPi example gave this error.
```
Pi is roughly 3.14374
14/05/14 18:16:19 ERROR Utils: Uncaught exception in thread SparkListenerBus
scala.runtime.NonLocalReturnControl$mcV$sp
```
This is due to the catch-all in the SparkListenerBus, which logged control throwable used
by scala system

Author: Tathagata Das <tathagata.das1565@gmail.com>

Closes #783 from tdas/controlexception-fix and squashes the following commits:

a466c8d [Tathagata Das] Ignored control exceptions when logging all exceptions.
(cherry picked from commit ad4e60ee7e2c49c24a9972312915f7f7253c7679)

Signed-off-by: Patrick Wendell <pwendell@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/ba871235
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/ba871235
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/ba871235

Branch: refs/heads/branch-1.0
Commit: ba871235f0d01093475547e74a125c10dd2123bb
Parents: 9f0f2ec
Author: Tathagata Das <tathagata.das1565@gmail.com>
Authored: Wed May 14 21:13:41 2014 -0700
Committer: Patrick Wendell <pwendell@gmail.com>
Committed: Wed May 14 21:14:21 2014 -0700

----------------------------------------------------------------------
 core/src/main/scala/org/apache/spark/util/Utils.scala | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/ba871235/core/src/main/scala/org/apache/spark/util/Utils.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/util/Utils.scala b/core/src/main/scala/org/apache/spark/util/Utils.scala
index d041bfa..388f722 100644
--- a/core/src/main/scala/org/apache/spark/util/Utils.scala
+++ b/core/src/main/scala/org/apache/spark/util/Utils.scala
@@ -1149,6 +1149,8 @@ private[spark] object Utils extends Logging {
     try {
       f
     } catch {
+      case ct: ControlThrowable =>
+        throw ct
       case t: Throwable =>
         logError(s"Uncaught exception in thread ${Thread.currentThread().getName}", t)
         throw t


Mime
View raw message