From dev-return-60323-archive-asf-public=cust-asf.ponee.io@spamassassin.apache.org Mon Jul 6 01:31:51 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8EE07180652 for ; Mon, 6 Jul 2020 03:31:51 +0200 (CEST) Received: (qmail 53202 invoked by uid 500); 6 Jul 2020 01:31:50 -0000 Mailing-List: contact dev-help@spamassassin.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@spamassassin.apache.org Received: (qmail 53187 invoked by uid 99); 6 Jul 2020 01:31:50 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jul 2020 01:31:50 +0000 Received: from bz-he-de.apache.org (bz-he-de.apache.org [148.251.237.210]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTPS id 7690240413 for ; Mon, 6 Jul 2020 01:31:49 +0000 (UTC) Received: by bz-he-de.apache.org (ASF Mail Server at bz-he-de.apache.org, from userid 33) id 2CC636A006A; Mon, 6 Jul 2020 01:31:48 +0000 (UTC) From: bugzilla-daemon@spamassassin.apache.org To: dev@spamassassin.apache.org Subject: [Bug 7833] New: SPF does not check for empty string Date: Mon, 06 Jul 2020 01:31:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Spamassassin X-Bugzilla-Component: Plugins X-Bugzilla-Version: SVN Trunk (Latest Devel Version) X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: nyt-apachebz@countercultured.net X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@spamassassin.apache.org X-Bugzilla-Target-Milestone: Undefined X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bz.apache.org/SpamAssassin/ Auto-Submitted: auto-generated MIME-Version: 1.0 https://bz.apache.org/SpamAssassin/show_bug.cgi?id=3D7833 Bug ID: 7833 Summary: SPF does not check for empty string Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All OS: All Status: NEW Severity: normal Priority: P2 Component: Plugins Assignee: dev@spamassassin.apache.org Reporter: nyt-apachebz@countercultured.net Target Milestone: Undefined I was looking at the SPF code between 3.4 and 4.0 and I think I see an issu= e in 4.0 where the $sender variable is only checked for existence, but it may be empty. https://github.com/apache/spamassassin/blob/trunk/lib/Mail/SpamAssassin/Plu= gin/SPF.pm#L711 if (defined $sender) { does not check empty string Should be: if (defined $sender && $sender) { Again here: https://github.com/apache/spamassassin/blob/trunk/lib/Mail/SpamAssassin/Plu= gin/SPF.pm#L732 if (defined $sender) { Should be: if (defined $sender && $sender) { --=20 You are receiving this mail because: You are the assignee for the bug.=