spamassassin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzilla-dae...@spamassassin.apache.org
Subject [Bug 7833] New: SPF does not check for empty string
Date Mon, 06 Jul 2020 01:31:47 GMT
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7833

            Bug ID: 7833
           Summary: SPF does not check for empty string
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Plugins
          Assignee: dev@spamassassin.apache.org
          Reporter: nyt-apachebz@countercultured.net
  Target Milestone: Undefined

I was looking at the SPF code between 3.4 and 4.0 and I think I see an issue in
4.0 where the $sender variable is only checked for existence, but it may be
empty.


https://github.com/apache/spamassassin/blob/trunk/lib/Mail/SpamAssassin/Plugin/SPF.pm#L711
    if (defined $sender) {

does not check empty string

Should be:

    if (defined $sender && $sender) {


Again here:

https://github.com/apache/spamassassin/blob/trunk/lib/Mail/SpamAssassin/Plugin/SPF.pm#L732

      if (defined $sender) {

Should be:

    if (defined $sender && $sender) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
Mime
View raw message