Mailing-List: contact dev-help@spamassassin.apache.org; run by ezmlm
Precedence: bulk
From: bugzilla-daemon@bugzilla.spamassassin.org
To: dev@spamassassin.apache.org
Subject: [Bug 5893] bayes_sql_override_username is ignored if value evaultes
 to 'false'
In-Reply-To: <bug-5893-26@https.issues.apache.org/SpamAssassin/>
References: <bug-5893-26@https.issues.apache.org/SpamAssassin/>
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Message-Id: <20090806190235.5FEC0234C044@brutus.apache.org>
Date: Thu,  6 Aug 2009 12:02:35 -0700 (PDT)

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5893


Mark Martinec <Mark.Martinec@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|Undefined                   |3.3.0


--- Comment #1 from Mark Martinec <Mark.Martinec@ijs.si>  2009-08-06 12:02:33 PST ---
Another manifestation of nonpedantic practice in some parts of code
where user-supplied strings are evaluated in places as Perl booleans,
instead of being tested for being defined or for being an empty string,
just like in Bug 5965.

I hope I caught all such cases dealing with username.
If not, please report and re-open.


  Bug 5893 (and Bug 5965): bayes_sql_override_username is ignored
  if value evalutes to 'false'
Sending        lib/Mail/SpamAssassin/BayesStore/MySQL.pm
Sending        lib/Mail/SpamAssassin/BayesStore/SQL.pm
Sending        lib/Mail/SpamAssassin/Client.pm
Sending        lib/Mail/SpamAssassin/SQLBasedAddrList.pm
Transmitting file data ....
Committed revision 801771 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=801771 ).

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.