Mailing-List: contact dev-help@spamassassin.apache.org; run by ezmlm
Precedence: bulk
From: bugzilla-daemon@bugzilla.spamassassin.org
To: dev@spamassassin.apache.org
Subject: [Bug 5841] [review] AWL plugin prints status regardless debug option
 is set or not
In-Reply-To: <bug-5841-26@https.issues.apache.org/SpamAssassin/>
References: <bug-5841-26@https.issues.apache.org/SpamAssassin/>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Message-Id: <20081016154726.AC048234C22F@brutus.apache.org>
Date: Thu, 16 Oct 2008 08:47:26 -0700 (PDT)

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5841


Mark Martinec <Mark.Martinec@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |needs 0.1 votes for 3.2


--- Comment #4 from Mark Martinec <Mark.Martinec@ijs.si>  2008-10-16 08:47:26 PST ---
The patch is ok with me, although perhaps too targeted to that specific
problem, while other plugins might want to benefit too from knowing
in what environment SpamAssassin is running - but that can be changed
later when need arises.

Checking the Hudson output, probably related to this patch:

t/whitelist_addrs...............1..35
[...]
ok 13
Unknown open() mode '>&' at t/whitelist_addrs.t line 95.
dubious
        Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED tests 14-35

It doesn't fail on my FreeBSD, so it might be Solaris-specifix,
or version-of-perl -specific.

Assuming the t/whitelist_addrs.t can be / will be fixed,
here is my
+0.9  (and an additional 0.1 if Hudson will be happy)


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.