Mailing-List: contact dev-help@spamassassin.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of jm@jmason.org designates
 72.232.31.42 as permitted sender)
To: "Daryl C. W. O'Shea" <spamassassin@dostech.ca>
cc: Sidney Markowitz <sidney@sidney.com>, dev@spamassassin.apache.org
Subject: Re: 3.2.4? 
In-Reply-To: <4764DBAD.3060604@dostech.ca> 
From: jm@jmason.org (Justin Mason)
Date: Mon, 17 Dec 2007 09:49:42 +0000
Sender: jm@jmason.org
Message-Id: <20071217094942.22C94F583E@jmason.org>


Daryl C. W. O'Shea writes:
> Sidney Markowitz wrote:
> > Daryl C. W. O'Shea wrote, On 16/12/07 7:42 PM:
> >> It appears to be a rule in the process of being removed, but left in 
> >> place to avoid lint failures.
> >>
> >> [dos@cyan 3.2]$ pwd; grep "score DRUG_RA_PRICE" *
> >> /home/dos/sasvn/rules/branches/3.2
> >> 50_scores.cf:score DRUG_RA_PRICE 0 # n=1 n=3
> >> [dos@cyan 3.2]$
> > 
> > But I just removed it from branches/3.2/rules/50_scores.cf so that it
> > would stop producing a failure in the 3.2 branch make test of t/meta.t.
> > Does that automatically migrate over to rules/branches/3.2/50_scores.cf
> > and if it does, then will that result in sa-update giving DRUG_RA_PRICE
> > a default score of 1 instead of 0?
> 
> No they don't sync.  Somebody probably screwed up removing only a part 
> of it from branches/3.2/rules and didn't do anything with 
> rules/branches/3.2 (which is really common for some reason... I usually 
> review all the commits and sync/fix things before I make an update).

Yeah, I suspect that was me. :(   Having 2 indepedent rule dirs for 3.2 is
too difficult and a bad idea; I suggest when we get to 3.3.x, we ensure
there's only 1.

--j.