sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cris Rockwell (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SLING-9915) Remove deprecated flags for SlingAnnotationsTestRunner and TestReference
Date Mon, 30 Nov 2020 16:43:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240865#comment-17240865
] 

Cris Rockwell commented on SLING-9915:
--------------------------------------

Thanks [~bdelacretaz] for the tips. After reviewing the maven-failsafe-plugin instructions
(1) debugging access to the test worked. Debugging the actual test Sling instance also worked
with a separate debugger configured in {{pax.vm.options}} as suggested in the pom properties,
and while running both debuggers. It may be useful to add a few comments in the project about
these debugging procedures.


{code:java}
<pax.vm.options>
-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5015
</pax.vm.options>
{code}
 
 
 
Thank you for fixing the tests with your commit  [https://github.com/apache/sling-org-apache-sling-junit-core/commit/4aa41bcb60c64eb0de795e54774e8f45c7e4f1aa |https://github.com/apache/sling-org-apache-sling-junit-core/commit/4aa41bcb60c64eb0de795e54774e8f45c7e4f1aa.]I've
reviewed the changes. Seems two fixes were needed: * Properly installing the org.apache.sling.junit.core
bundle (and not embedding it)

{code:java}
mavenBundle().groupId("org.apache.sling").artifactId("org.apache.sling.junit.core").versionAsInProject(){code}
 * Properly satisfying the {{osgi.contract=JavaJSONP}} the capability (not setting Provide-Capability
in the annotation-it testing bundle) 

{code:java}
SlingOptions.versionResolver.setVersion("org.apache.sling", "org.apache.sling.commons.johnzon",
"1.2.6");
{code}
 
 
(1) [https://maven.apache.org/surefire/maven-failsafe-plugin/examples/debugging.html]

> Remove deprecated flags for SlingAnnotationsTestRunner and TestReference
> ------------------------------------------------------------------------
>
>                 Key: SLING-9915
>                 URL: https://issues.apache.org/jira/browse/SLING-9915
>             Project: Sling
>          Issue Type: Task
>          Components: JUnit Core
>    Affects Versions: JUnit Core 1.1.0
>            Reporter: Cris Rockwell
>            Assignee: Cris Rockwell
>            Priority: Minor
>              Labels: test, tools
>
> As per discussion thread
> https://www.mail-archive.com/dev@sling.apache.org/msg100097.html
> Revert this commit
> https://github.com/apache/sling-org-apache-sling-junit-core/commit/c7f98b1172126f1e5f961ec9d17d12b239c34e0d
> Reviving annotations
> @TestReference
> @SlingAnnotationsTestRunner 
> Review docs and suggest updates 
> https://sling.apache.org/documentation/development/sling-testing-tools.html
> https://sling.apache.org/documentation/bundles/org-apache-sling-junit-bundles.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message