sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #57: Fixes bug: jarStartOrder can only be set for FMs in the source folder.
Date Tue, 07 Jul 2020 07:12:38 GMT

cziegeler commented on a change in pull request #57:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/57#discussion_r450655445



##########
File path: src/main/java/org/apache/sling/feature/maven/mojos/AbstractFeatureMojo.java
##########
@@ -163,7 +163,7 @@
      * The start level for the attached jar/bundle.
      */
     @Parameter(name=FeatureProjectConfig.CFG_JAR_START_ORDER)
-    private int jarStartOrder;

Review comment:
       I think leaving this as an int is slightly better as this way Maven does the conversion
and reports on the error.
   You can check for greater zero later on (instead of a null check)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message