From dev-return-107873-archive-asf-public=cust-asf.ponee.io@sling.apache.org Mon Jun 29 11:53:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 26B3818065B for ; Mon, 29 Jun 2020 13:53:02 +0200 (CEST) Received: (qmail 39721 invoked by uid 500); 29 Jun 2020 11:53:01 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 39690 invoked by uid 99); 29 Jun 2020 11:53:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jun 2020 11:53:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9874B42285 for ; Mon, 29 Jun 2020 11:53:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 1A939781F2B for ; Mon, 29 Jun 2020 11:53:00 +0000 (UTC) Date: Mon, 29 Jun 2020 11:53:00 +0000 (UTC) From: "Carsten Ziegeler (Jira)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-9555) Define ResourceChange.ChangeType also as constant string values MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147713#comment-17147713 ] Carsten Ziegeler commented on SLING-9555: ----------------------------------------- .bq You cannot know. If some implementor has created a field with the same name already in a subclass of ResourceChangeListener it may break! But that's totally independent whether the version has a minor or patch version change. > Define ResourceChange.ChangeType also as constant string values > --------------------------------------------------------------- > > Key: SLING-9555 > URL: https://issues.apache.org/jira/browse/SLING-9555 > Project: Sling > Issue Type: Improvement > Components: API > Reporter: Konrad Windszus > Assignee: Konrad Windszus > Priority: Major > Fix For: API 2.22.2 > > Time Spent: 1h > Remaining Estimate: 0h > > As all annotation values have to be provided as constants (e.g. in https://docs.osgi.org/javadoc/r6/residential/org/osgi/service/component/annotations/Component.html#property()) and conversion from {{Enum}} to {{String}} cannot be resolved at compile time all enum values of {{ResourceChange.ChangeType}} should also be provided as String constants. > Something like this does not work > {code} > @Component(property = { ResourceChangeListener.CHANGES+"="+ResourceChange.ChangeType.REMOVED.toString()} > ) > {code} > Compare with https://stackoverflow.com/a/13253879. -- This message was sent by Atlassian Jira (v8.3.4#803005)