sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SLING-9555) Define ResourceChange.ChangeType also as constant string values
Date Mon, 29 Jun 2020 10:15:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147672#comment-17147672
] 

Konrad Windszus commented on SLING-9555:
----------------------------------------

Baselining requires a minor version increase
{code}
[ERROR] Baseline mismatch for package org.apache.sling.api.resource.observation, MINOR change.
Current is 1.2.3, repo is 1.2.2, suggest 1.3.0 or -
MINOR                PACKAGE    org.apache.sling.api.resource.observation
  MINOR              INTERFACE  org.apache.sling.api.resource.observation.ResourceChangeListener
    ADDED            FIELD      CHANGE_ADDED
      ADDED          ACCESS     final
      ADDED          ACCESS     static
      ADDED          CONSTANT   ADDED
      ADDED          RETURN     java.lang.String
    ADDED            FIELD      CHANGE_CHANGED
      ADDED          ACCESS     final
      ADDED          ACCESS     static
      ADDED          CONSTANT   CHANGED
      ADDED          RETURN     java.lang.String
    ADDED            FIELD      CHANGE_PROVIDER_ADDED
      ADDED          ACCESS     final
      ADDED          ACCESS     static
      ADDED          CONSTANT   PROVIDER_ADDED
      ADDED          RETURN     java.lang.String
    ADDED            FIELD      CHANGE_PROVIDER_REMOVED
      ADDED          ACCESS     final
      ADDED          ACCESS     static
      ADDED          CONSTANT   PROVIDER_REMOVED
      ADDED          RETURN     java.lang.String
    ADDED            FIELD      CHANGE_REMOVED
      ADDED          ACCESS     final
      ADDED          ACCESS     static
      ADDED          CONSTANT   REMOVED
      ADDED          RETURN     java.lang.String
  REMOVED            VERSION    1.2.2
  ADDED              VERSION    1.2.3
{code}

> Define ResourceChange.ChangeType also as constant string values
> ---------------------------------------------------------------
>
>                 Key: SLING-9555
>                 URL: https://issues.apache.org/jira/browse/SLING-9555
>             Project: Sling
>          Issue Type: Improvement
>          Components: API
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: API 2.22.2
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> As all annotation values have to be provided as constants (e.g. in https://docs.osgi.org/javadoc/r6/residential/org/osgi/service/component/annotations/Component.html#property())
and conversion from {{Enum}} to {{String}} cannot be resolved at compile time all enum values
of {{ResourceChange.ChangeType}} should also be provided as String constants.
> Something like this does not work
> {code}
> @Component(property = { ResourceChangeListener.CHANGES+"="+ResourceChange.ChangeType.REMOVED.toString()}
> )
> {code}
> Compare with https://stackoverflow.com/a/13253879.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message