sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SLING-9555) Define ResourceChange.ChangeType also as constant string values
Date Mon, 29 Jun 2020 05:35:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147560#comment-17147560
] 

Carsten Ziegeler commented on SLING-9555:
-----------------------------------------

While I see the reason behind this change, it has a minor version increase of the package
- which requires a new resource resolver implementation release. I suggest we change that
to a patch version update only, to not break existing RR impls

> Define ResourceChange.ChangeType also as constant string values
> ---------------------------------------------------------------
>
>                 Key: SLING-9555
>                 URL: https://issues.apache.org/jira/browse/SLING-9555
>             Project: Sling
>          Issue Type: Improvement
>          Components: API
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: API 2.22.2
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> As all annotation values have to be provided as constants (e.g. in https://docs.osgi.org/javadoc/r6/residential/org/osgi/service/component/annotations/Component.html#property())
and conversion from {{Enum}} to {{String}} cannot be resolved at compile time all enum values
of {{ResourceChange.ChangeType}} should also be provided as String constants.
> Something like this does not work
> {code}
> @Component(property = { ResourceChangeListener.CHANGES+"="+ResourceChange.ChangeType.REMOVED.toString()}
> )
> {code}
> Compare with https://stackoverflow.com/a/13253879.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message