sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Munteanu (Jira)" <j...@apache.org>
Subject [jira] [Resolved] (SLING-7731) Call to addService is no longer needed for modification events in SlingAuthenticatorServiceListener
Date Thu, 18 Jun 2020 08:40:00 GMT

     [ https://issues.apache.org/jira/browse/SLING-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Munteanu resolved SLING-7731.
------------------------------------
    Resolution: Fixed

PR applied, thanks a lot [~vfrey] and [~taestell] for the contribution. I'll start a release
vote early next week at the latest.

> Call to addService is no longer needed for modification events in SlingAuthenticatorServiceListener
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SLING-7731
>                 URL: https://issues.apache.org/jira/browse/SLING-7731
>             Project: Sling
>          Issue Type: Bug
>          Components: Authentication
>    Affects Versions: Auth Core 1.3.18
>            Reporter: Vincent Frey
>            Assignee: Robert Munteanu
>            Priority: Major
>             Fix For: Auth Core 1.4.8
>
>
> After introduction of modifiedService(...) method in SlingAuthenticatorServiceListener,
calling addService(...) is no longer needed for modification event.
> [https://github.com/apache/sling-org-apache-sling-auth-core/blob/master/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticatorServiceListener.java#L85]
> Therefore line 85 should be changed from:
> {code}
> if ((event.getType() & (ServiceEvent.REGISTERED | ServiceEvent.MODIFIED)) != 0) {
> {code}
> to:
> {code}
> if ((event.getType() & ServiceEvent.REGISTERED) != 0) {
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message