sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-org-apache-sling-api] rombert commented on a change in pull request #22: SLING-9555 add constants for values of property "resource.change.types"
Date Mon, 29 Jun 2020 08:22:18 GMT

rombert commented on a change in pull request #22:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/22#discussion_r446853204



##########
File path: src/main/java/org/apache/sling/api/resource/observation/package-info.java
##########
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-@Version("1.2.2")
+@Version("1.3.0")

Review comment:
       I assume `bnd` requested this change. But it it really needed? I think adding new constants
to an interface would not break implementors of that interface, so this should be 1.2.3 instead.

##########
File path: src/main/java/org/apache/sling/api/resource/observation/ResourceChangeListener.java
##########
@@ -92,11 +92,41 @@
      * If this property is missing, added, removed and changed events for resources
      * and added and removed events for resource providers are reported.
      * If this property is invalid, the listener is ignored. The type of the property
-     * must either be String, or a String array. Valid values are the constants from
-     * {@link ResourceChange.ChangeType}.
+     * must either be String, or a String array. Valid values are the constants from this
class
+     * whose names are starting with {@code CHANGE_}. They map to one of the values of {@link
ResourceChange.ChangeType}.
      */
     String CHANGES = "resource.change.types";
 
+    /**
+     * String constant for {@link ResourceChange.ChangeType#ADDED}.
+     * @since 1.3.0 (Sling API Bundle 2.23.0)
+     */
+    String CHANGE_ADDED = "ADDED";

Review comment:
       Any reason for not directly using `ResourceChange.ChangeType.ADDED.toString()`? Same
for the other constants.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message