sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #56: SLING-9489 Make it possible to compare parts of feature models
Date Thu, 18 Jun 2020 09:06:38 GMT

cziegeler commented on a change in pull request #56:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/56#discussion_r442080737



##########
File path: src/main/java/org/apache/sling/feature/maven/mojos/AnalyseFeaturesMojo.java
##########
@@ -98,6 +99,20 @@ public URL provide(final ArtifactId id) {
         }
         getLog().debug(MessageUtils.buffer().strong("Scanner").a(" successfully set up").toString());
 
+        FeatureProvider featureProvider = new FeatureProvider() {

Review comment:
       It would be good to use new BaseFeatureProvider() from the AbstractFeatureMojo class




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message