From dev-return-105580-archive-asf-public=cust-asf.ponee.io@sling.apache.org Thu Apr 9 16:25:53 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 67B00180634 for ; Thu, 9 Apr 2020 18:25:53 +0200 (CEST) Received: (qmail 28636 invoked by uid 500); 9 Apr 2020 16:25:52 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 28623 invoked by uid 99); 9 Apr 2020 16:25:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Apr 2020 16:25:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9781D181312 for ; Thu, 9 Apr 2020 16:25:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.249 X-Spam-Level: X-Spam-Status: No, score=-0.249 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.2, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=gmx.net Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 07Bz0O-O74at for ; Thu, 9 Apr 2020 16:25:49 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=212.227.15.18; helo=mout.gmx.net; envelope-from=konrad_w@gmx.de; receiver= Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 0B86DBB8F9 for ; Thu, 9 Apr 2020 16:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1586449541; bh=5Gm1ZIuumU3ROxKoZNjbZQLrvetAVjL85GSSqkGD2lY=; h=X-UI-Sender-Class:From:Subject:Date:References:To:In-Reply-To; b=a4rVb2p+hlFasGSAg2HGrTf0zbWDUQfKR52MIJgBXJjSj5S+evdFB/cLUYCBjfWGF PRNpGw4+0hwguR/FElCZr5jzvsnZcK2tewToidowe59QESjyPyp/wi0o8gHthy1QBB oHYdI5DZ9ceS7xE6DLMWhOhgqlB2UZGcHE7WzupE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.22] ([188.192.10.49]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mj8mV-1iqYdM2J9h-00fEBg for ; Thu, 09 Apr 2020 18:25:41 +0200 From: Konrad Windszus Content-Type: multipart/alternative; boundary="Apple-Mail=_A6F34EC8-E155-439D-81A0-DCF3D6A9BBF9" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [VOTE] Deprecate org.apache.launchpad.test-services-war Date: Thu, 9 Apr 2020 18:25:40 +0200 References: <92416d65e5d23f2cc41f74154ad3d05f8c4b16f0.camel@apache.org> To: dev@sling.apache.org In-Reply-To: <92416d65e5d23f2cc41f74154ad3d05f8c4b16f0.camel@apache.org> Message-Id: <85A2847B-9CFA-4A03-97BC-E158FDD428AA@gmx.de> X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Provags-ID: V03:K1:wGvrmm8DIZcEKDpS5ws8o9TJI2MQINvUvOMMBpCsnInYWerql5e KkzusPgO2vCHyN8Y/And6sV0kT1f7sCDS23EC11dvx+dim+hjZR89dHh1rwsBBIXislClUb 1K6JxCrxMTIRgbew7H19aHu0f5mF3v+9jF7mWUQKm6njMUPzJ79emIwNGauCt1M7n/U+IV0 cFWh3ToJ4ZZ5Q3zIfa1qA== X-UI-Out-Filterresults: notjunk:1;V03:K0:O1W/TnfpTQg=:tod1NIEbArmBaykBktJTzV WDMII8pQKmZhJ1BIRn94h2hSRlcQ5eNGPG0BQz93hLvH+U0NnfpKc6Lj3zg/jg0p/Nzed9Mnr yD6zApSSEpby397UM5JHDXGBcuAihMUdJ7iLXGTEmJmLVzxbbYH+bgJYt+RQfbfXG7Jz8Zp32 jXVkmKwSmdZkucd7e9s4+CnTRwkk486SQCDDQ3dkFfSB0GFVPiuk/WLeVusVUzsJDQpxEXgxj RJQCMmAE72EApMHEVZRd/O05ph+BIEbL7ZR1CxsyfDFy/OziaIoLcQM5PMOzvO8NEXYG4V2TS 2saHA/xXd9JBp4kVq3LjuzlySgyn2zO9hhELaR5y9wsGFtNVLzXoVmv7OKUpxu+Eh40vKl83d XGyFO0KS1An6e7YYQaoJOdvUYH2suXMbpCZOJ+YBIdLqCoaB4OQGNrbdkmjdIQfwxk3y/xG2v 5eRfn4utR3JnhhsLblW7+upciiz4Ch9Gpjtt5y+awU5zCDtEQ8ChETZS9GQ5ZbNW5DTJ+5xE6 6q6j9VJUSEjFktHqf/qJjOrSCm5N1K+LFTCkfKqNwR1Dw3FU4J5v3+ZlN+vaAuYs+Qjba6saf 5lpcYduTdIAUEjDKFACdJMyIqyBwGtBDOJiTRWhpeXQ63ZLWc2CEKnFmsiGbEQ4FJN62t3KPG +DSBLH4QHDG8yD88uIVcacFdRbZcjvyB7IqjqdBsrpPkw5g6pueEgLQ5Ck139Z/ikqe/Dm+p7 jTMXjXwdlkKNAi/dObCyRWhKLQLKwYSspCwyJ2gRN8nGBjhjCFQKdu28A0reAp6dyF94ggY3l TbajHH8CPdOtx3TKUWOcmaf/b9vOOmYI/SWrnsTis9D5oTI+3L7xYcU2gi++Nd6Ovk+a8y52A 8KnIq/YoALEvb6NtjzIJm0Z7+Kz+zzd9IXr3yDums2QE4x/Vs0QyZXJbdw96OgEbqa9+Hom2A nUev7gxv/xtWJ5bijPo7jbPRbCnOFJCKRS0tI6uM5oOnwN1cX2eR14zZj9l8/ulROwipCxZ5Y UzKp7l39kG4vRD0XHSnhK7BbYI5lFBTdqWG7h7OkZ0GqRCUmH7P42njCkpYotSy7Men4LEvqj prFr7wlYXKvkiY2dc+vQB0XI8zXZUznKsHG5mOs+tBzmQjhNS5WUDOIeuNeUh+CKGtdSvrUA2 ffSSj6yAaVxQIF8ffrfl6AcEg0QZJ1InDvTwjLRgQcR7uBKtm6SjrEeGn2UmVKxMQRJ0WQx8G 2NhcN/WzQo/ineesV --Apple-Mail=_A6F34EC8-E155-439D-81A0-DCF3D6A9BBF9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii For me the tests are interesting (although an edge case). But the deployment should not be as a bundle into OSGi but rather as a = dedicated 2nd war = (https://www.eclipse.org/jetty/documentation/9.4.x/jetty-maven-plugin.html= #deploy-war-running-pre-assembled-war = ) while executing = https://github.com/apache/sling-org-apache-sling-launchpad-testing-war/blo= b/fa39f6a3c238cd79da4962ebf3f827f19b567016/pom.xml#L128=20 That was also the intention I guess as services-war have the packaging = war = (https://github.com/apache/sling-org-apache-sling-launchpad-test-services-= war/blob/e93ea20c1f62d8219efd0e749c7e12f4225695d2/pom.xml#L31). Konrad If we deprecate (and I am not against it) we should IMHO deprecate = https://github.com/apache/sling-org-apache-sling-launchpad-testing-war = = at the same time and say War in general may or may not work! > On 9. Apr 2020, at 18:15, Robert Munteanu wrote: >=20 > Hi, >=20 > With SLING-8680 [1] we seem to have found a interesting scenario in = our > testing setup: >=20 > - org.apache.sling.launchpad.test-services-war [2] is packaged as a = WAR > file with a manifest, exposing two Servlets > - before SLING-8680 [1] we only checked for a manifest when > transforming resources, now we reject the WAR file > - we have two tests that validate that those servlets are running > properly - see WarSelectorServletTest.java [3] >=20 > IMO we should not test or support this scenario (WAR files installed = as > OSGi bundles) as it's a quite convoluted and specific scenario. >=20 > Therefore I propose that we retire this module following our = Deprecated > Sling Modules process and delete the two tests. >=20 > Please vote to accept this retirement. This majority vote is open for > at least 72 hours. >=20 > Thanks, > Robert >=20 > [1]: https://issues.apache.org/jira/browse/SLING-8680 > [2]: = https://github.com/apache/sling-org-apache-sling-launchpad-test-services-w= ar/blob/e93ea20c1f62d8219efd0e749c7e12f4225695d2/pom.xml > [3]: = https://github.com/apache/sling-org-apache-sling-launchpad-integration-tes= ts/blob/49e5c948a0115566f778a5696e7f3df45e5dd3f5/src/main/java/org/apache/= sling/launchpad/webapp/integrationtest/servlets/resolution/WarSelectorServ= letTest.java >=20 --Apple-Mail=_A6F34EC8-E155-439D-81A0-DCF3D6A9BBF9--