sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SLING-9378) When internalRedirect and sling:match maps are added, filterPattern doesn't work
Date Fri, 17 Apr 2020 13:37:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085751#comment-17085751
] 

Konrad Windszus commented on SLING-9378:
----------------------------------------

The documentation at https://sling.apache.org/documentation/the-sling-engine/filters.html
explicitly talks about request paths
bq. Restrict the filter to resource paths that match the supplied regular expression. This
does not refer to the request path, but rather to the resolved resource path excluding selectors,
extension and suffix Requires Sling Engine 2.4.0.

But in contrast the javadoc at https://github.com/apache/sling-org-apache-sling-servlets-annotations/blob/8ed7e020df1f0a409edd6997382d7dc6ba14bee4/src/main/java/org/apache/sling/servlets/annotations/SlingServletFilter.java#L64
talks about resource paths.

IMHO it used to be  request path, i.e. the behaviour of `sling.filter.pattern` should be restored.
In addition a filter against resolved resource paths might be introduced.

> When internalRedirect and sling:match maps are added, filterPattern doesn't work
> --------------------------------------------------------------------------------
>
>                 Key: SLING-9378
>                 URL: https://issues.apache.org/jira/browse/SLING-9378
>             Project: Sling
>          Issue Type: Bug
>    Affects Versions: Engine 2.6.16, Engine 2.6.18
>            Reporter: Ankita Agarwal
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> ***sling.filter.pattern=/abcd/.** doesn't work after a map is added with internalRedirect
and sling:match. This is a issue due to [SLING-7759|https://issues.apache.org/jira/browse/SLING-7759]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message