sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SLING-9218) Incomplete OSGi manifest for Commons Johnzon 1.2.0
Date Wed, 22 Apr 2020 11:42:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-9218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089591#comment-17089591
] 

Carsten Ziegeler commented on SLING-9218:
-----------------------------------------

I do not really care that much about the scope :) The missing capability is more important.
I personally would change the scope to "provided" as you don't need that dependency when you
include commons.johnzon in your pom as our bundle contains everything. But as users should
rather just use the api dependency anyway, it doesn't really matter that much

> Incomplete OSGi manifest for Commons Johnzon 1.2.0
> --------------------------------------------------
>
>                 Key: SLING-9218
>                 URL: https://issues.apache.org/jira/browse/SLING-9218
>             Project: Sling
>          Issue Type: Bug
>    Affects Versions: Commons Johnzon 1.2.0
>            Reporter: Eric Norman
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: Commons Johnzon 1.2.2
>
>
> It looks to me that any bundle that attempts to depend on the new org.apache.sling.commons.johnzon:1.2.0
bundle produces a manifest for the new bundle that makes it not activate when deployed to
the sling runtime.
>   
>  For example, the manifest now includes this instruction in the manifest:
>   
> {quote}Require-Capability: osgi.contract;osgi.contract=JavaJSONP;filter:="(&(
>   osgi.contract=JavaJSONP)(version=1.1.0))",osgi.ee;filter:="(&(osgi.ee
>   =JavaSE)(version=1.8))"
> {quote}
>  
>   
>  But it doesn't look like the org.apache.sling.commons.johnzon:1.2.0 manifest declares
that it provides that JavaJSONP capability.
>   
>  It appears that the equivalent "Provide-Capability" instruction is in the original org.apache.geronimo.specs.geronimo-json_1.1_spec
artifact.  It contains the following in it's manifest but the o.a.s.commons.johnzon does
not do the same when it wraps the bundle:
>   
> {quote}Provide-Capability: osgi.contract;osgi.contract=JavaJSONP;uses:="javax
>   .json,javax.json.spi,javax.json.stream";version:List<Version>="1.1,1.
>   0"
> {quote}
>  
>  
> Alternatively, maybe there is a convenient way to adjust the BND instructions so one
can depend on the org.apache.sling.commons.johnzon:1.2.0 artifact without requiring the osgi.contract=JavaJSONP capability
in the manifest?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message