sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Kuijpers (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SLING-8858) Model Cache causes NPE in sling.models.impl 1.4.10+
Date Mon, 16 Mar 2020 10:37:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060107#comment-17060107
] 

Henry Kuijpers commented on SLING-8858:
---------------------------------------

Can someone please have a look at the provided PR?

We're currently affected by this bug and I think the fix is quite straightforward.

 

WDYT [~cziegeler]?

> Model Cache causes NPE in sling.models.impl 1.4.10+
> ---------------------------------------------------
>
>                 Key: SLING-8858
>                 URL: https://issues.apache.org/jira/browse/SLING-8858
>             Project: Sling
>          Issue Type: Bug
>          Components: Sling Models
>    Affects Versions: Sling Models Impl 1.4.10
>         Environment: Java SE 1.8.0_231
>            Reporter: Frank Pauleickhoff
>            Priority: Major
>             Fix For: Sling Models Impl 1.4.14
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In AEM 6.4 ServicePack 6 we face NullPointerExceptions when using the Sling model cache
that used to work before (in SP 3).
> *Exception Stacktrace is:*
> {code:java}
> 22.11.2019 15:29:22.525 *ERROR* [127.0.0.1 [1574432957337] GET /content/mypage.html HTTP/1.1]
org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught SlingException
> org.apache.sling.scripting.sightly.SightlyException: org.apache.sling.api.SlingException:
Cannot get DefaultSlingScript: org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: org.apache.sling.api.SlingException:
Cannot get DefaultSlingScript: org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: Identifier xx.xxx.MyModel
cannot be correctly instantiated by the Use API
> [...]
> Caused by: java.lang.NullPointerException: null
>  at org.apache.sling.models.impl.ModelAdapterFactory.internalCreateModel(ModelAdapterFactory.java:407)
>  at org.apache.sling.models.impl.ModelAdapterFactory.createModel(ModelAdapterFactory.java:314)
> {code}
> Problem seems to be related to introduction of WeakReferences in SLING-7586. Without
knowing any details and being deeply into the Sling Model Caching implementation, I think
a null-check is missing for "SoftReference" in Line 407:
> {code:java}
> SoftReference<Object> SoftReference = adaptableCache.get(requestedType);
> ModelType cachedObject = (ModelType) SoftReference.get();
> {code}
> That seems to cause caching to throw NPE for any not yet cached model.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message