sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell commented on a change in pull request #14: SLING-9174: Added the code for enhancement
Date Thu, 05 Mar 2020 20:25:39 GMT
jfmitchell commented on a change in pull request #14: SLING-9174: Added the code for enhancement
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/14#discussion_r388544309
 
 

 ##########
 File path: src/main/java/org/apache/sling/dynamicinclude/IncludeTagFilter.java
 ##########
 @@ -166,8 +167,22 @@ private String getUrl(Configuration config, SlingHttpServletRequest
request) {
     private String buildUrl(Configuration config, SlingHttpServletRequest request) {
         final Resource resource = request.getResource();
 
+        // The below code gets the path to the XF and then passes it to the buildUrl method
+        // so that the path to the component is replaced with path to the XF
+        ValueMap vm = resource.adaptTo(ValueMap.class);
 
 Review comment:
   Yes - but this code is going to run for *all* configured resource types.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message