From dev-return-104170-archive-asf-public=cust-asf.ponee.io@sling.apache.org Fri Feb 28 23:34:15 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 238BD180636 for ; Sat, 29 Feb 2020 00:34:15 +0100 (CET) Received: (qmail 76524 invoked by uid 500); 28 Feb 2020 23:34:14 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 76512 invoked by uid 99); 28 Feb 2020 23:34:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Feb 2020 23:34:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 725DB1A33C9 for ; Fri, 28 Feb 2020 23:34:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.399 X-Spam-Level: X-Spam-Status: No, score=-0.399 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=me.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id eUNsWUDKVEAR for ; Fri, 28 Feb 2020 23:34:12 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=17.58.23.195; helo=mr85p00im-ztdg06021801.me.com; envelope-from=schaefera@me.com; receiver= Received: from mr85p00im-ztdg06021801.me.com (mr85p00im-ztdg06021801.me.com [17.58.23.195]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 104CEBB80F for ; Fri, 28 Feb 2020 23:34:11 +0000 (UTC) X-ASF-DKIM-Sig: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1582932851; bh=MHa4kOSyWbBsRZ0wYIVlcudirr3Ls/zgd/2h88x7x1o=; h=From:Content-Type:Subject:Date:To:Message-Id; b=lHGnxeFtjFW1ui/1iWIEWuJXv/voxpUBDRBZDWP7Lvhps/qT6kcxy8CehvJD4dPHl 86uTjA+y0/3XzBWVy10qmSw7Un/+PJSly3WoF6ouEg7cJ6QJbr+q4epQD+SbaaOAZA /XwvGOCpGCovwZGNDbV8Ti/d1472hL0kWh8mQBVrWhiHDZjlMmAMnUT0damdPxi7SC xWME2nBypHYbu+51hvSjgzjcAsf44ZBipekcADYNWMJ5m8hcZGmECc0e29JHGAUz7h L31ozy3HJETIab6FENvau6CeE4K1RHaM6a4+RoARPcWWcRNqki1C656IC3oc7sx9bC aMMyux6oaV4kA== Received: from [192.168.1.55] (unknown [47.148.18.99]) by mr85p00im-ztdg06021801.me.com (Postfix) with ESMTPSA id 04EB3180461; Fri, 28 Feb 2020 23:34:10 +0000 (UTC) From: Andreas Schaefer Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [VOTE] Release Sling Feature Model 1.1.4, Feature Model IO 1.3.0, Feature Model Analyser 1.2.6, slingfeature-maven-plugin 1.1.16 Date: Fri, 28 Feb 2020 15:34:10 -0800 References: <0FC895ED-98E5-4D3E-A10D-F86B0A20E9B4@me.com> To: dev@sling.apache.org, davidb@apache.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2020-02-28_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-2002280171 Hi David For a while now I am trying to get the include-artifact enhanced and I = had many issues trying to figure out why some configurations do not = work. =46rom my experience IT tests do not only show how it is done but also = allow devs to debug them. Also an IT project has the advantage that it = is easy to make sure it is still up to date whereas documentation tends = to get out of date pretty easily. If speed is an issue for having many ITs then why not create a separate = folder (extended-it) and then have the execution into a profile. Finally I am not concerned that much about coverage even though this is = an important part but more about showcasing how goals are used. - Andy > On Feb 28, 2020, at 12:41 AM, davidb@apache.org wrote: >=20 > Hi Andreas, >=20 > At least for the new api-regions-crossfeature-duplicates mojo, > documentation is here: > = https://github.com/apache/sling-slingfeature-maven-plugin#api-regions-cros= sfeature-duplicates >=20 > This Mojo is well covered with unit tests (> 90% coverage). While IT = tests > have their use and can also be handy to learn from how a feature is = used, > they are generally a lot slower than unit tests. Adding them to the = default > test set doesn't scale IMHO, as over time it slows down the build a = lot. We > can already see this with the Maven invoker based tests today. For = just a > handful of tests they take up most of the time of the slingfeature = maven > plugin build. >=20 > So my 2c would be that good documentation and unit tests are sometimes = good > enough. If we go the route of having many IT tests I think we should > separate them out in a separate component so that they are no run for = every > normal build. >=20 > Best regards, >=20 > David >=20 > On Thu, 27 Feb 2020 at 19:20, Andreas Schaefer = > wrote: >=20 >> +1 (non-binding) >>=20 >> I would ask that new features in Slingfeature Maven Plugin have at = least >> one corresponding IT test. The documentation is not in-depth and so = an IT >> test would help users to understand how the plugin is used. >>=20 >> - Andy >>=20 >>> On Feb 27, 2020, at 5:41 AM, davidb@apache.org wrote: >>>=20 >>> Hi all, >>>=20 >>> I would like to call the release on the following Sling Apache >> components: >>>=20 >>> Feature Model 1.1.4 >>> https://issues.apache.org/jira/projects/SLING/versions/12346848 >>>=20 >>> Feature Model IO 1.3.0 >>> https://issues.apache.org/jira/projects/SLING/versions/12346849 >>>=20 >>> Feature Model Analyser 1.2.6 >>> https://issues.apache.org/jira/projects/SLING/versions/12346850 >>>=20 >>> slingfeature-maven-plugin 1.1.16 >>> https://issues.apache.org/jira/projects/SLING/versions/12346858 >>>=20 >>> Staging repository: >>> = https://repository.apache.org/content/repositories/orgapachesling-2212 >>>=20 >>> You can use this UNIX script to download the release and verify the >>> signatures: >>>=20 >> = https://gitbox.apache.org/repos/asf?p=3Dsling-tooling-release.git;a=3Dblob= ;f=3Dcheck_staged_release.sh;hb=3DHEAD >>>=20 >>> Usage: >>> sh check_staged_release.sh 2212 /tmp/sling-staging >>>=20 >>> Please vote to approve this release: >>>=20 >>> [ ] +1 Approve the release >>> [ ] -1 Don't release, because ... >>>=20 >>> This majority vote is open for at least 72 hours. >>>=20 >>> Best regards, >>>=20 >>> David >>=20 >>=20