sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Munteanu <romb...@apache.org>
Subject Re: Redirect Provider
Date Sat, 08 Feb 2020 12:18:17 GMT
Hi Ian,

On Sat, 2020-02-08 at 09:48 +0000, Ian Boston wrote:
> Hi,
> The PRs have been opened, see the issue.
> I will do complete implementations to verify it works as required in
> AEM.
> I would also like to insure no disruption to Sling, and since it's
> been a
> long time since I did this, how do run full CI/CD and integrate a new
> API
> in Sling ? (a pointer would be great).
> 

I have added some instructions at 

  https://sling.apache.org/contributing.html#testing

Let me know whether that is enough or it needs expansions.

Thanks,
Robert

> Best Regards
> Ian
> 
> 
> On Sat, 8 Feb 2020 at 09:23, Ian Boston <ieb@tfd.co.uk> wrote:
> 
> > Hi,
> > Opened [1] to track the work.
> > Best Regards
> > Ian
> > 
> > 1 https://issues.apache.org/jira/browse/SLING-9060
> > 
> > On Wed, 5 Feb 2020 at 22:12, Ian Boston <ieb@tfd.co.uk> wrote:
> > 
> > > Hi,
> > > Ok.
> > > 
> > > o.a.s.api.redirect for the API, and a patch to the Get servlet to
> > > use the
> > > API.
> > > Will do PRs shortly.
> > > 
> > > Best Regards
> > > Ian
> > > 
> > > 
> > > On Tue, 4 Feb 2020 at 14:13, Bertrand Delacretaz <
> > > bdelacretaz@apache.org>
> > > wrote:
> > > 
> > > > On Tue, Feb 4, 2020 at 1:58 PM Ian Boston <ieb@tfd.co.uk>
> > > > wrote:
> > > > > ...New package, agreed, no ripples.
> > > > > o.a.s.api.response ? ...
> > > > 
> > > > o.a.s.api.redirect is more specific and I think having packages
> > > > with
> > > > few interfaces is fine?
> > > > 
> > > > The existing api.auth and api.security packages for example
> > > > only have
> > > > 3 items each.
> > > > 
> > > > It has the benefit of OSGi package versioning being very
> > > > specific.
> > > > 
> > > > -Bertrand
> > > > 


Mime
View raw message