sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Schaefer <schaef...@me.com.INVALID>
Subject Re: [VOTE] Release Sling Feature Model 1.1.4, Feature Model IO 1.3.0, Feature Model Analyser 1.2.6, slingfeature-maven-plugin 1.1.16
Date Fri, 28 Feb 2020 23:34:10 GMT
Hi David

For a while now I am trying to get the include-artifact enhanced and I had many issues trying
to figure out why some configurations do not work.

From my experience IT tests do not only show how it is done but also allow devs to debug them.
Also an IT project has the advantage that it is easy to make sure it is still up to date whereas
documentation tends to get out of date pretty easily.

If speed is an issue for having many ITs then why not create a separate folder (extended-it)
and then have the execution into a profile.

Finally I am not concerned that much about coverage even though this is an important part
but more about showcasing how goals are used.

- Andy

> On Feb 28, 2020, at 12:41 AM, davidb@apache.org wrote:
> 
> Hi Andreas,
> 
> At least for the new api-regions-crossfeature-duplicates mojo,
> documentation is here:
> https://github.com/apache/sling-slingfeature-maven-plugin#api-regions-crossfeature-duplicates
> 
> This Mojo is well covered with unit tests (> 90% coverage). While IT tests
> have their use and can also be handy to learn from how a feature is used,
> they are generally a lot slower than unit tests. Adding them to the default
> test set doesn't scale IMHO, as over time it slows down the build a lot. We
> can already see this with the Maven invoker based tests today. For just a
> handful of tests they take up most of the time of the slingfeature maven
> plugin build.
> 
> So my 2c would be that good documentation and unit tests are sometimes good
> enough. If we go the route of having many IT tests I think we should
> separate them out in a separate component so that they are no run for every
> normal build.
> 
> Best regards,
> 
> David
> 
> On Thu, 27 Feb 2020 at 19:20, Andreas Schaefer <schaefera@me.com.invalid>
> wrote:
> 
>> +1 (non-binding)
>> 
>> I would ask that new features in Slingfeature Maven Plugin have at least
>> one corresponding IT test. The documentation is not in-depth and so an IT
>> test would help users to understand how the plugin is used.
>> 
>> - Andy
>> 
>>> On Feb 27, 2020, at 5:41 AM, davidb@apache.org wrote:
>>> 
>>> Hi all,
>>> 
>>> I would like to call the release on the following Sling Apache
>> components:
>>> 
>>> Feature Model 1.1.4
>>> https://issues.apache.org/jira/projects/SLING/versions/12346848
>>> 
>>> Feature Model IO 1.3.0
>>> https://issues.apache.org/jira/projects/SLING/versions/12346849
>>> 
>>> Feature Model Analyser 1.2.6
>>> https://issues.apache.org/jira/projects/SLING/versions/12346850
>>> 
>>> slingfeature-maven-plugin 1.1.16
>>> https://issues.apache.org/jira/projects/SLING/versions/12346858
>>> 
>>> Staging repository:
>>> https://repository.apache.org/content/repositories/orgapachesling-2212
>>> 
>>> You can use this UNIX script to download the release and verify the
>>> signatures:
>>> 
>> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>>> 
>>> Usage:
>>> sh check_staged_release.sh 2212 /tmp/sling-staging
>>> 
>>> Please vote to approve this release:
>>> 
>>>  [ ] +1 Approve the release
>>>  [ ] -1 Don't release, because ...
>>> 
>>> This majority vote is open for at least 72 hours.
>>> 
>>> Best regards,
>>> 
>>> David
>> 
>> 


Mime
View raw message