sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-slingfeature-maven-plugin] schaefa commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes
Date Fri, 14 Feb 2020 00:30:28 GMT
schaefa commented on a change in pull request #49: Replacement PR for #41 with a clean set
of changes
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#discussion_r379194603
 
 

 ##########
 File path: src/main/java/org/apache/sling/feature/maven/mojos/IncludeArtifactMojo.java
 ##########
 @@ -62,9 +113,6 @@
 
     @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
-        if (includeArtifactClassifier == null) {
 
 Review comment:
   Thanks for pointing this out. My IT tests did not cover the issue with already cached features
which I fixed.
   The reason to allow no classifier is that simple projects do not need as the group / artifact
id and version are enough.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message