From dev-return-102752-archive-asf-public=cust-asf.ponee.io@sling.apache.org Tue Jan 28 20:48:10 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BA872180658 for ; Tue, 28 Jan 2020 21:48:09 +0100 (CET) Received: (qmail 79000 invoked by uid 500); 28 Jan 2020 20:48:09 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 78988 invoked by uid 99); 28 Jan 2020 20:48:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jan 2020 20:48:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 375DB1A418B for ; Tue, 28 Jan 2020 20:48:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=me.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5ZFwzTNqDPJ6 for ; Tue, 28 Jan 2020 20:48:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=17.58.23.196; helo=mr85p00im-ztdg06021701.me.com; envelope-from=schaefera@me.com; receiver= Received: from mr85p00im-ztdg06021701.me.com (mr85p00im-ztdg06021701.me.com [17.58.23.196]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 2CAC87DD96 for ; Tue, 28 Jan 2020 20:48:03 +0000 (UTC) X-ASF-DKIM-Sig: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1580244481; bh=mACPS6iwhvD8p2leGEsmkSAIOXd7o0zdMr/nu/JEodE=; h=From:Content-Type:Subject:Date:To:Message-Id; b=N3kjhr4Ka/MhqLMUPLdr5vQtGHUPGX7AjrxJ7YtrVpQrUoVlk8QkRGzXxd+12b/F1 63N2NMaYO/o9YZms28tJ+W20yrqyMkg9CmPj9cZ2YHIHN7/DEnIklFn6IFv/QSEXP/ MbtLQZvV6xSTGjqpg2kNGP6vKqEkRtJPRkFgl78D4p/ZHjoXPPUuWA5UhkRUQWFJJa SOAQ5BcOHtL094Zq0NtJQoaqKKIZvYcHxgb25ygLvwCLGUGAdytEZLeuWy4LWbIsJw vmHeq2BBZ3uPE+D/9UZd6OolUKfK37GGBIa+TTjsyFNVP2549g+RTKG9UMkTnZs4xR GGD9nXvkNlyTw== Received: from [192.168.1.55] (unknown [47.148.18.99]) by mr85p00im-ztdg06021701.me.com (Postfix) with ESMTPSA id 3B7F6A00323 for ; Tue, 28 Jan 2020 20:48:01 +0000 (UTC) From: Andreas Schaefer Content-Type: multipart/alternative; boundary="Apple-Mail=_2AA99A12-4C9E-4395-BEED-C02F0DEAA877" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [VOTE] Promote sling-org-apache-sling-feature-starter / sling-slingstart-feature-maven-plugin to its own Sling Module Date: Tue, 28 Jan 2020 12:48:00 -0800 References: <3FE1DC42-0177-4CE1-AB2F-0963512C80E5@me.com> <807789E2-A631-4C3E-A592-24EC44244265@me.com> <0bd3d953-e933-d749-a77a-825abbbafc45@apache.org> <14b9905d-b579-239b-e133-0bd7e0feae42@apache.org> <9EA58D0B-40A1-46AC-AA4F-264BB773285C@me.com> To: dev@sling.apache.org In-Reply-To: <9EA58D0B-40A1-46AC-AA4F-264BB773285C@me.com> Message-Id: <9CB0C60B-BD03-432A-B5FB-9F41C3CCCA6E@me.com> X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2020-01-28_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-2001280155 --Apple-Mail=_2AA99A12-4C9E-4395-BEED-C02F0DEAA877 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi I created a simple project that illustrates on how the Sling Feature = Starter and the Slingstart Feaute Maven Plugin can be used: https://github.com/schaefa/sling-fm-sample = The README.md has the instructions on how to build, launch and access = it. - Andy > On Jan 27, 2020, at 9:28 AM, Andreas Schaefer = wrote: >=20 > Hi Carsten >=20 > Yes, you could say that. It provides these additional features: >=20 > - Executable Jar file > - Provides a Sling 12 FM > - Allows to execute Sling in the background with a listening port for = management > - Allows to stop the Sling instance from another process / terminal > - Part of the Sling Start Feature Maven Plugin as it needs to execute = Sling in the background and then end it at the end >=20 > If you are thinking to incorporate this into the Feature Launcher that = is fine with me. >=20 > - Andy >=20 >> On Jan 22, 2020, at 10:23 PM, Carsten Ziegeler = wrote: >>=20 >> Hi Andreas, >>=20 >> thanks, so the feature starter is - simplified - an improved feature = launcher already containing all the required pieces including a basic = feature model. Is that correct? >>=20 >> Regards >> Carsten >>=20 >> On 23.01.2020 01:42, Andreas Schaefer wrote: >>> Hi Carsten >>> That is not what I had in mind. The Feature Starter is only = containing the Feature Launcher and its necessary components to get it = working (extensions) and the Sling FM file. The rest is downloaded and = started through the Feature Launcher as if you started it with the = Feature Launcher. >>> The JAR file has two options: >>> 1) Provide an override of the Sling FM to run your very own Sling or = Sling / Customized FMs >>> 2) Provide additional FMs to add your customized FMs to the released = Sling FM / instance >>> The rest of the options are the same as for the Sling Starter even = though the Launcher Home is not supported yet. >>> This means that a user can either start Sling or can start its own = project(s) + Sling with the Sling Feature Starter. >>> - Andy >>>> On Jan 21, 2020, at 8:54 AM, Carsten Ziegeler = wrote: >>>>=20 >>>> So it seems you are suggestion, that if someone wants to build a = Sling application, you clone/fork the feature-starter project, add your = own feature models and build the project, right? So this is kind of a = template for an own application project. >>>>=20 >>>> Lets assume we go this route, how would we change the current = sling-starter project, which is the demo application we have? >>>>=20 >>>> Regards >>>> Carsten >>>>=20 >>>> On 20.01.2020 07:05, Carsten Ziegeler wrote: >>>>> Can you explain a little bit more how this works for users wanting = to build an application? >>>>> Today, you can create your own maven project, add/import = provisioning models and build a startable jar (and a webapp which we = don't need to support for feature models right now). You can then use = this jar without any tooling. >>>>> Thanks >>>>> Carsten >>>>> On 20.01.2020 01:58, Andreas Schaefer wrote: >>>>>> As far as I see the 'sling-org-apache-sling-feature-starter=E2=80=99= this is not just a test but rather the official way to start Sling XX. = It does have the option to add additional Feature Models (customer FMs) = to the startup and we can also add startup scripts so that it can be = launched as a Unix style service. >>>>>>=20 >>>>>> I am fine with both approaches but we should make a decision one = way or the other. >>>>>>=20 >>>>>> - Andy >>>>>>=20 >>>>>>> On Jan 19, 2020, at 3:13 AM, Carsten Ziegeler = wrote: >>>>>>>=20 >>>>>>> Sorry for getting late to this, but is the = slingstart-feature-maven-plugin also creating the startable jar? >>>>>>>=20 >>>>>>> While I suggested to create separate modules (which I continue = to think is good), I'm a little bit worried about = "org-apache-sling-feature-starter" - The current starter project is a = demo setup for Sling, making it easy to try out and test Sling. >>>>>>> Maybe it would be better to have the feature equivalent on the = master branch of "sling-org-apache-sling-starter" and we move current = master branch to a "provisioning-model" branch. >>>>>>>=20 >>>>>>> Regards >>>>>>> Carsten >>>>>>>=20 >>>>>>> On 17.01.2020 17:41, Andreas Schaefer wrote: >>>>>>>> Hi >>>>>>>> This is a vote to promote the = sling-org-apache-sling-feature-starter and = sling-slingstart-feature-maven-plugin to their own Sling Module. This = first module is the Feature Model counterpart of the = sling-org-apache-sling-starter and will create an executable JAR file. = The second is the counterpart of the sling-slingstart-maven-plugin which = will start and stop a Sling Instance from a Maven run and is mostly used = to run Integration Tests. >>>>>>>> Sling Feature Starter: >>>>>>>> 1. Code Location: both are in the =E2=80=98sling-whiteboard=E2=80= =99 under 'sling-org-apache-sling-feature-starter` folder >>>>>>>> 2. Proposed Github Repo name (I just added feature into the = name): >>>>>>>> - sling-org-apache-sling-feature-starter >>>>>>>> 3. Proposed artifact ids (group id: org.apache.sling) >>>>>>>> - org.apache.sling.feature.starter >>>>>>>> Sling Start Feature Maven Plugin: >>>>>>>> 1. Code Location: both are in the =E2=80=98sling-whiteboard=E2=80= =99 under 'sling-slingstart-feature-maven-plugin` folder >>>>>>>> 2. Proposed Github Repo names (I just added feature into the = name): >>>>>>>> - sling-slingstart-feature-maven-plugin >>>>>>>> 3. Proposed artifact ids (group id: org.apache.sling) >>>>>>>> - slingstart-feature-maven-plugin >>>>>>>> As requested by Carsten I created separate modules for the = Feature counterparts. The modules work but the are not finished. The = Sling Feature Starter is actually using the Sling Start Feature Maven = Plugin to run the IT tests. >>>>>>>> - Andy >>>>>>>=20 >>>>>>> --=20 >>>>>>> --=20 >>>>>>> Carsten Ziegeler >>>>>>> Adobe Research Switzerland >>>>>>> cziegeler@apache.org >>>>>>=20 >>>>=20 >>>> --=20 >>>> -- >>>> Carsten Ziegeler >>>> Adobe Research Switzerland >>>> cziegeler@apache.org >>=20 >> --=20 >> -- >> Carsten Ziegeler >> Adobe Research Switzerland >> cziegeler@apache.org >=20 --Apple-Mail=_2AA99A12-4C9E-4395-BEED-C02F0DEAA877--