From dev-return-102730-archive-asf-public=cust-asf.ponee.io@sling.apache.org Tue Jan 28 12:32:50 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0D629180658 for ; Tue, 28 Jan 2020 13:32:49 +0100 (CET) Received: (qmail 6289 invoked by uid 500); 28 Jan 2020 12:32:49 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 6277 invoked by uid 99); 28 Jan 2020 12:32:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jan 2020 12:32:49 +0000 From: GitBox To: dev@sling.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsling-org-apache-sling-distribution-core=5D_act?= =?utf-8?q?inium15_commented_on_issue_=2334=3A_SLING-9030_less_verbose_log?= =?utf-8?q?ging_for_retryable-distribution-failures_=E2=80=A6?= Message-ID: <158021476925.31974.2771231128278792596.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 28 Jan 2020 12:32:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit actinium15 commented on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures … URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/34#issuecomment-579223873 >I suggest to simply lower the logging to WARN in general here. I didn't want to lose the full exception and stack trace, and (for obvious reasons) didn't want to include that in the WARN log. >I think it is not a good practice though to check for the debug level and then decide between logging on ERROR or WARN level Would you prefer if I just log the exception additionally if debug is enabled? (as in `if (log.isDebugEnabled()) log.error(e);`). Or are you of the opinion that logging the full exception and trace is of not value at any log level? \cc: @tmaret ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services