sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-org-apache-sling-distribution-core] actinium15 commented on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …
Date Tue, 28 Jan 2020 12:32:49 GMT
actinium15 commented on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures
…
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/34#issuecomment-579223873
 
 
   >I suggest to simply lower the logging to WARN in general here.
   
   I didn't want to lose the full exception and stack trace, and (for obvious reasons) didn't
want to include that in the WARN log.
   
   >I think it is not a good practice though to check for the debug level and then decide
between logging on ERROR or WARN level
   
   Would you prefer if I just log the exception additionally if debug is enabled? (as in `if
(log.isDebugEnabled()) log.error(e);`). Or are you of the opinion that logging the full exception
and trace is of not value at any log level?
   
   \cc: @tmaret

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message