From dev-return-101707-archive-asf-public=cust-asf.ponee.io@sling.apache.org Thu Dec 19 23:43:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1716918037A for ; Fri, 20 Dec 2019 00:43:01 +0100 (CET) Received: (qmail 78017 invoked by uid 500); 19 Dec 2019 23:43:01 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 78002 invoked by uid 99); 19 Dec 2019 23:43:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Dec 2019 23:43:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 909C1E0239 for ; Thu, 19 Dec 2019 23:43:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 061CB780193 for ; Thu, 19 Dec 2019 23:43:00 +0000 (UTC) Date: Thu, 19 Dec 2019 23:43:00 +0000 (UTC) From: "Radu Cotescu (Jira)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (SLING-8933) The IncludeRuntimeExtension doesn't correctly normalise paths when using the path manipulation options MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-8933?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1700= 0177#comment-17000177 ]=20 Radu Cotescu edited comment on SLING-8933 at 12/19/19 11:42 PM: ---------------------------------------------------------------- Fixed in commits [5cd359b|https://github.com/apache/sling-org-apache-sling-= scripting-sightly/commit/5cd359b] and [2262199|https://github.com/apache/sl= ing-org-apache-sling-scripting-sightly/commit/2262199]. was (Author: radu.cotescu): Fixed in [commit 5cd359b|https://github.com/apache/sling-org-apache-sling-s= cripting-sightly/commit/5cd359b]. > The IncludeRuntimeExtension doesn't correctly normalise paths when using = the path manipulation options > -------------------------------------------------------------------------= ----------------------------- > > Key: SLING-8933 > URL: https://issues.apache.org/jira/browse/SLING-8933 > Project: Sling > Issue Type: Bug > Components: Scripting > Affects Versions: Scripting HTL Engine 1.2.0-1.4.0 > Reporter: Radu Cotescu > Assignee: Radu Cotescu > Priority: Major > Fix For: Scripting HTL Engine 1.3.2-1.4.0, Scripting HTL Test= ing 1.0.20-1.4.0, Scripting HTL Testing Content 1.0.18-1.4.0 > > > The=C2=A0{{prependPath}}=C2=A0and {{appendPath}}=C2=A0options passed to {= {data-sly-resource}} or {{data-sly-include}} seem to have wrongly been hand= led by the {{UriManipulationFilter}} until SLING-8896, when the filter was = changed to be applied in all other contexts, except for {{data-sly-resource= }}, {{data-sly-include}}, {{data-sly-use}}, {{data-sly-call}}, {{data-sly-t= emplate}}. > This led to the discovery that the {{data-sly-include}} plugin doesn't co= rrectly normalise the paths when path options are passed. E.g.: > {code:html} > > {code} > will now fail, since the generated script path will be {{/apps/myproject/= components/templatesnav.html}} - notice the missing {{/}} character. -- This message was sent by Atlassian Jira (v8.3.4#803005)