From dev-return-101097-archive-asf-public=cust-asf.ponee.io@sling.apache.org Tue Dec 3 08:07:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E4B4618065B for ; Tue, 3 Dec 2019 09:07:03 +0100 (CET) Received: (qmail 68098 invoked by uid 500); 3 Dec 2019 08:07:03 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 67954 invoked by uid 99); 3 Dec 2019 08:07:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Dec 2019 08:07:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 55E37E2589 for ; Tue, 3 Dec 2019 08:07:02 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id A00DE78062F for ; Tue, 3 Dec 2019 08:07:00 +0000 (UTC) Date: Tue, 3 Dec 2019 08:07:00 +0000 (UTC) From: "Mohit Arora (Jira)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-8869?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1698= 6688#comment-16986688 ]=20 Mohit Arora commented on SLING-8869: ------------------------------------ [~ashishc]=C2=A0Thanks for pointing it out. I have updated the patch. > SimpleHttpDistributionTransport does not refresh the secret for token bas= ed implementations. > -------------------------------------------------------------------------= ------------------- > > Key: SLING-8869 > URL: https://issues.apache.org/jira/browse/SLING-8869 > Project: Sling > Issue Type: Bug > Components: Content Distribution > Reporter: Mohit Arora > Priority: Critical > Fix For: Content Distribution Core 0.4.2 > > Attachments: SLING-8869.patch > > > While saving the \{{contextKeyExecutor}} in \{{DistributionTransportConte= xt}} map, it is not expected that the secret associated with the executor c= ould be expired. This can happen in case of access token based implementati= ons where the token is expired after a certain period of time and has to be= refreshed. > The code to refresh the token is written in the secret provider but since= the executor is [cached in the map|[https://github.com/apache/sling-org-ap= ache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/dis= tribution/transport/impl/SimpleHttpDistributionTransport.java#L208]] the se= crets are not refreshed. It works fine for credentials based secret provide= r but not for access token based. -- This message was sent by Atlassian Jira (v8.3.4#803005)