sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Radu Cotescu (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (SLING-8933) The IncludeRuntimeExtension doesn't correctly normalise paths when using the path manipulation options
Date Thu, 19 Dec 2019 23:43:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000177#comment-17000177
] 

Radu Cotescu edited comment on SLING-8933 at 12/19/19 11:42 PM:
----------------------------------------------------------------

Fixed in commits [5cd359b|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/5cd359b]
and [2262199|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/2262199].


was (Author: radu.cotescu):
Fixed in [commit 5cd359b|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/5cd359b].

> The IncludeRuntimeExtension doesn't correctly normalise paths when using the path manipulation
options
> ------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-8933
>                 URL: https://issues.apache.org/jira/browse/SLING-8933
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: Scripting HTL Engine 1.2.0-1.4.0
>            Reporter: Radu Cotescu
>            Assignee: Radu Cotescu
>            Priority: Major
>             Fix For: Scripting HTL Engine 1.3.2-1.4.0, Scripting HTL Testing 1.0.20-1.4.0,
Scripting HTL Testing Content 1.0.18-1.4.0
>
>
> The {{prependPath}} and {{appendPath}} options passed to {{data-sly-resource}} or
{{data-sly-include}} seem to have wrongly been handled by the {{UriManipulationFilter}} until
SLING-8896, when the filter was changed to be applied in all other contexts, except for {{data-sly-resource}},
{{data-sly-include}}, {{data-sly-use}}, {{data-sly-call}}, {{data-sly-template}}.
> This led to the discovery that the {{data-sly-include}} plugin doesn't correctly normalise
the paths when path options are passed. E.g.:
> {code:html}
> <sly data-sly-include="${'nav.html' @ prependPath='/apps/myproject/components/templates'}"></sly>
> {code}
> will now fail, since the generated script path will be {{/apps/myproject/components/templatesnav.html}}
- notice the missing {{/}} character.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message