sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Radu Cotescu <r...@apache.org>
Subject Re: [apache/sling-org-apache-sling-scripting-jsp] SLING-8867 - Enhance the pageContext with the values provided by the SlingBindings (#3)
Date Mon, 02 Dec 2019 12:51:14 GMT
Hi Bertrand,

> On 2 Dec 2019, at 12:54, Bertrand Delacretaz <bdelacretaz@apache.org> wrote:
> 
> On Fri, Nov 29, 2019 at 4:39 PM Radu Cotescu <notifications@github.com> wrote:
>> 
>> wrapped the default PageContext in order to be able to provide the JSP
>> scripts with bindings entries, through the pageContext...
> 
> I think it would be good to add a brief comment to
> SlingJspPageContext, to explain why it's here and mention that the
> wrapped Page Context's attributes take precedence by design.


I’ve added this info in https://github.com/apache/sling-org-apache-sling-scripting-jsp/commit/cf8343a
<https://github.com/apache/sling-org-apache-sling-scripting-jsp/commit/cf8343a>.

Thanks,
Radu
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message