sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-org-apache-sling-installer-core] kwin commented on a change in pull request #5: SLING-8419 JSON serializer for configurations
Date Sun, 22 Dec 2019 20:57:47 GMT
kwin commented on a change in pull request #5: SLING-8419 JSON serializer for configurations
URL: https://github.com/apache/sling-org-apache-sling-installer-core/pull/5#discussion_r360728275
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -37,84 +38,89 @@
         by supplying input streams and dictionaries.
     </description>
 
+    <properties>
+        <sling.java.version>8</sling.java.version>
+    </properties>
     <scm>
         <connection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-installer-core.git</connection>
         <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-installer-core.git</developerConnection>
         <url>https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-installer-core.git</url>
-      <tag>HEAD</tag>
-  </scm>
+        <tag>HEAD</tag>
+    </scm>
 
-	<build>
-		<plugins>
-			<plugin>
-				<groupId>org.apache.felix</groupId>
-				<artifactId>maven-bundle-plugin</artifactId>
-				<extensions>true</extensions>
-				<configuration>
-					<instructions>
-						<Bundle-Activator>
-							org.apache.sling.installer.core.impl.Activator
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.felix</groupId>
+                <artifactId>maven-bundle-plugin</artifactId>
+                <extensions>true</extensions>
+                <configuration>
+                    <instructions>
+                        <Bundle-Activator>
+                            org.apache.sling.installer.core.impl.Activator
                         </Bundle-Activator>
                         <Conditional-Package>
                             org.apache.felix.configurator.impl.json,
-                            org.apache.felix.configurator.impl.model                    
       
+                            org.apache.felix.configurator.impl.model,
+                            org.apache.sling.feature,
+                            org.apache.sling.feature.*
                         </Conditional-Package>
                         <Embed-Dependency>
-                            geronimo-json_1.0_spec,johnzon-core,org.apache.felix.converter,
 
 Review comment:
   Either we need to rely on Aries SPI Fly or embed Sling Commons JSON, otherwise we run into
classloader issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message