sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-org-apache-sling-distribution-core] mohiaror commented on issue #28: SLING-8869 SimpleHttpDistributionTransport does not refresh the secret for token based implementations.
Date Thu, 05 Dec 2019 16:20:56 GMT
mohiaror commented on issue #28: SLING-8869 SimpleHttpDistributionTransport does not refresh
the secret for token based implementations.
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/28#issuecomment-562202291
 
 
   @tmaret 
   
   > it seems that Sonar is correct here, DistributionTransportSecret#getAuthSecret may
return null as documented in the API.
   
   > The PR should handle null returned by DistributionTransportSecret#asCredentialsMap
   
   We are already checking the null occurrence of DistributionTransportSecret#asCredentialsMap
in the code. The sonar report is actually showing the NPE for _secret_ returned by DistributionTransportSecretProvider#getSecret
Line#235 which is old code and I assume this error must have been coming in previous reports
as well. Nevertheless, I will add a patch for that in the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message