sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SLING-8842) CP Converter creates packaging "slingfeature" instead of "slingosgifeature"
Date Wed, 13 Nov 2019 09:23:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973164#comment-16973164
] 

Carsten Ziegeler commented on SLING-8842:
-----------------------------------------

[~mikagoeckel] I can't find this line in
https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/FeatureJSONWriter.java

> CP Converter creates packaging "slingfeature" instead of "slingosgifeature"
> ---------------------------------------------------------------------------
>
>                 Key: SLING-8842
>                 URL: https://issues.apache.org/jira/browse/SLING-8842
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>    Affects Versions: Feature Model IO 1.1.2
>            Reporter: Mika Goeckel
>            Priority: Minor
>
> I used the sling-feature-converter-maven-plugin to create features.json files from the
sling-starter provisioning txt files.
> The converter creates feature files with packaging „slingfeature“ but installes
them using „slingosgifeature“.
>  
> Then I use the slingfeature-maven-plugin to create a „full“ version from the files
created above. The -full file has an „assembled-features“ section containing the single
feature files with packaging „slingfeature“, itself on the other hand declares a packaging „slingosgifeature“.
>  
> Now I try to use the -full feature json as prototype for my own feature.json.
> When I now use slingfeature-maven-plugin to assemble the artifacts, it tries to find
them with packaging „slingfeature“ (as declared in the assembled-section) – but can't
find them as they have been installed as „slingosgifeature“.
>  
> Could it be, that this is coming from FeatureJSONWriter Line 519:
>  
> // When providing a classifier a type must be provided and so we set it to 'slingfeature'
>            idString =
>                groupId + "/" +
>                (nameOption.isEmpty() ? name : nameOption) + "/" +
>                version +
>                (nameOption.isEmpty() ? "" :
>                    "/slingfeature/" + name );



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message