From dev-return-100390-archive-asf-public=cust-asf.ponee.io@sling.apache.org Fri Oct 25 13:05:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9108F180660 for ; Fri, 25 Oct 2019 15:05:05 +0200 (CEST) Received: (qmail 80143 invoked by uid 500); 25 Oct 2019 13:05:01 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 80053 invoked by uid 99); 25 Oct 2019 13:05:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Oct 2019 13:05:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A6F7DE2C65 for ; Fri, 25 Oct 2019 13:05:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 27C8C7803B2 for ; Fri, 25 Oct 2019 13:05:00 +0000 (UTC) Date: Fri, 25 Oct 2019 13:05:00 +0000 (UTC) From: =?utf-8?Q?J=C3=B6rg_Hoh_=28Jira=29?= To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-8802) JcrResourceBundle should not consider dictionaries with a basename, if no basename is provided MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-8802?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1695= 9747#comment-16959747 ]=20 J=C3=B6rg Hoh commented on SLING-8802: --------------------------------- I raised a PR for this: https://github.com/apache/sling-org-apache-sling-i1= 8n/pull/2 > JcrResourceBundle should not consider dictionaries with a basename, if no= basename is provided > -------------------------------------------------------------------------= --------------------- > > Key: SLING-8802 > URL: https://issues.apache.org/jira/browse/SLING-8802 > Project: Sling > Issue Type: Improvement > Components: i18n > Affects Versions: i18n 2.5.14 > Reporter: J=C3=B6rg Hoh > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In a situation where 2 dictionaries are available (one with a basename c= onfigured, the other without any basename), the {{JcrResourceBundle}} will = load (and merge) both if no basename is provided (see [1]). > This breaks applications where basenames are used to separate multiple Re= sourceBundles from each other, and there are definitely cases where the bas= ename is not provided (and thu assumed as {{null}}). > I would propose to make the behavior consistent and return only dictionar= ies with no basename configured if basename is null. > [1] https://github.com/apache/sling-org-apache-sling-i18n/blob/master/src= /main/java/org/apache/sling/i18n/impl/JcrResourceBundle.java#L340 -- This message was sent by Atlassian Jira (v8.3.4#803005)